[PATCH] Improved Water Rendering

[aeonios]

-Increases reflection and refraction texture sizes. -Changes the refraction function to be less extreme and to work better over a larger range of water depths. -Improves the reflection/fresnel function so that reflections fall off more naturally. -Reduces the intensity of sky reflections because the color is too extreme otherwise. -Reduces the distortion intensity for reflections to a more natural level.

-Cleans up the code a bit, removes old commented-out stuff and adds/improves comments in a few places.

[wraitii]

Code seems OK at first glance, I'll review the changes later, but there is one thing I'd suggest you go back on: refractions can actually benefit from a downscaled texture as it applies a rudimentary "blurring" effect, which looks better.

[gameboy]

I have tested it, but I don't see the effect of the water and the sun on your image. why?

[elexis]

When testing #3697, we also tested this patch, since it is included in attachment:trade-v2.3.patch:ticket:3697​. All three of us got errors and water that was rendered completely black. It apparently has something to do with the user.cfg (likely the one of a19).

[aeonios]

If you don't provide the error log then there's nothing I can do about it. :|

[fatherbushido]

aeonios : you won't get the errors while replaying ? I join the errors i got in console.

[aeonios]

hmm.. that looks like the patch is not being applied properly, or perhaps was not created properly. The variable it's saying was not declared definitely has a declaration and is only used within the ifdef where it was declared, so a garbled file seems most likely. I have no idea why that would happen though.

[elexis]

sample

[elexis]

• With the latest patch after compiling:

ERROR: Failed to compile shader 'shaders/glsl/water_high.fs':
Fragment shader failed to compile with the following errors:
ERROR: 0:260: error(#143) Undeclared identifier: refColor
ERROR: 0:260: error(#202) No matching overloaded function found: mix
ERROR: 0:260: error(#160) Cannot convert from: "const float" to: "highp 3-component vector of vec3"
ERROR: 0:331: error(#143) Undeclared identifier: alphaCoeff
ERROR: error(#273) 4 compilation errors.  No code generated

Options:

waterfancyeffects = "true"
waternormals = "false"
waterrealdepth = "false"
waterreflection = "false"
waterrefraction = "false"
watershadows = "true"
waterugly = "false"

Switching some functions (in particular water-refraction) triggers errors too.

• Why do you change things like ReflectionTextureSize to RefTextureSize? (Could the error even have something to do with this?) Ref reads less descriptive than Reflection.

• Comments should start with capital letters

• But the effect looks impressive and it should be committed in my opinion!