Opened 3 years ago

Closed 3 years ago

#3788 closed enhancement (wontfix)

Refactoring and clarifies gui subsystem source code

Reported by: Sergey Kushnirenko Owned by:
Priority: Nice to Have Milestone:
Component: Core engine Keywords: patch
Cc: Patch:

Description

I research some items in IGUIObject class and want to suggest refactoring which can class declaration easy and more clarify.

Attachments (2)

gui_subsystem_code_refactoring.patch (31.4 KB) - added by Sergey Kushnirenko 3 years ago.
gui_subsystem_code_refactoring.2.patch (31.0 KB) - added by Sergey Kushnirenko 3 years ago.

Download all attachments as: .zip

Change History (6)

Changed 3 years ago by Sergey Kushnirenko

comment:1 Changed 3 years ago by Sergey Kushnirenko

Priority: Should HaveNice to Have

Changed 3 years ago by Sergey Kushnirenko

comment:2 Changed 3 years ago by Sergey Kushnirenko

Format code like GameView? class

comment:3 in reply to:  2 Changed 3 years ago by Vladislav Belov

Replying to dalerank:

Format code like GameView? class

I think, it needs to add new lines between function declarations and inside of implementations.

And gui/IGUIObject.h:168:"Take focus!" is quite extra comment, do we need it?

Last edited 3 years ago by Vladislav Belov (previous) (diff)

comment:4 Changed 3 years ago by Itms

Keywords: simple review removed
Milestone: Backlog
Resolution: wontfix
Status: newclosed

Hi, thanks for the patch but unfortunately there is no need for such a refactoring. We only use a pimpl in GameView, that's not something we'd like to have everywhere.

Here are two issues that you should pay special attention to in your future patches:

  • We don't use auto, in order to know which type a variable is
  • Your cut-and-paste of Doxygen comments messed up the indentation (there is one space missing for each line)

Thanks for the work anyways, don't hesitate to ask on IRC if you don't know whether some change is wanted.

Note: See TracTickets for help on using tickets.