Opened 8 years ago

Closed 6 years ago

Last modified 6 years ago

#3824 closed defect (fixed)

[PATCH] WxWidgets 3.1 : Horizontal alignment flags are ignored in horizontal sizers

Reported by: spongebrot Owned by: Stephen Imhoff
Priority: If Time Permits Milestone: Alpha 23
Component: Atlas editor Keywords:
Cc: Patch:

Description (last modified by Stephen Imhoff)

I just compiled WxWidgets 3.1 to use with Atlas editor. When trying to run Atlas (same from Main-Menu or the .bat file) i get an assertion error: wxBoxSizer::DoInsert(): Horizontal alignment flags are ignored in horizontal sizers

[01]wxBoxSizer::DoInsert [02]PlayerSettingsControl::PlayerSettingsControl \source\tools\atlasui\scenarioeditor\sections\player\player.cpp:563

When i continue execution Atlas still starts and also the Player control is rendered correctly.

Attachments (1)

atlas_warning_fixes.patch (6.3 KB ) - added by Stephen Imhoff 8 years ago.
correct flags, normalize spelling

Download all attachments as: .zip

Change History (10)

comment:1 by Stephen Imhoff, 8 years ago

Keywords: review patch added
Milestone: BacklogAlpha 21
Owner: set to Stephen Imhoff
Status: newassigned
Summary: WxWidgets 3.1 : wxBoxSizer::DoInsert() : Horizontal alignment flags are ignored in horizontal sizers[PATCH] WxWidgets 3.1 : Horizontal alignment flags are ignored in horizontal sizers

by Stephen Imhoff, 8 years ago

Attachment: atlas_warning_fixes.patch added

correct flags, normalize spelling

comment:2 by Stephen Imhoff, 8 years ago

There were several instances of this, some of which don't show up until a menu is accessed. There was also one instance of CENTRE - everything else uses CENTER - so that was switched.

comment:3 by Itms, 8 years ago

Keywords: rfc added; review removed

Move tickets from the review queue to the rfc one.

comment:4 by Vladislav Belov, 8 years ago

Why .Expand() has removed from wxSizerFlags? The rest of the patch looks ok.

comment:5 by elexis, 8 years ago

Milestone: Alpha 21Alpha 22

Feature freeze in 2 days.

comment:6 by elexis, 7 years ago

Milestone: Alpha 22Work In Progress

Moving to the new WIP milestone.

comment:7 by Stephen Imhoff, 7 years ago

Description: modified (diff)

comment:8 by Vladislav Belov, 6 years ago

Resolution: fixed
Status: assignedclosed

In 20327:

Atlas: Cleanup horizontal alignment flags being ignored, fix warnings on a start.
Fix #3824
Patch by: Clockwork-Muse.
Reviewed by: vladislavbelov.
Differential Revision: https://code.wildfiregames.com/D824

comment:9 by Stan, 6 years ago

Keywords: patch rfc removed
Milestone: Work In ProgressAlpha 23
Note: See TracTickets for help on using tickets.