Modification of an Aura by technology bug.

[fatherbushido]

When working on #3792, i have a bug in code. I discussed of this with Sanderd17 :​irc.

In fact it is yet in current svn r17899.

• i build a wonder
• change perspective my ally capture it by wololo cheat code
• i change perspective, i build one for me
• i recapture its one by wololo
• i search the technology.

So i must get +50 bonus pop. But i have still the +10 one.

If i destroy both and rebuild one i have +50. If i had built only one and search the tech i would had +50

I tracked how auras calls AuraManager.js and i have exactly that : ( A means apply aura bonus (in AuraManager) R means remove aura bonus, 1 et 2 are players, 10 or 50 are the aura bonus)

A1 10, R1 10, A2 10, A1 10, R2 10, A1 10, R1 10, A1 50, R1 10, A1 50

So i should have +50 but i don't.

So there is a bug in AuraManager, or something wrong with Player component and maxpop.

[fatherbushido]

workaround, remove wonder auras, restore the tech, revert possibility to modify Player/MaxPopulation

[fatherbushido]

same workaround, depends if one want to remove useless (in this case) code or not

[fatherbushido]

another workaround, but this time #3792 can be more annoying...

[sanderd17]

In 17907:

Revert tech applying to auras due to issues. Patch by fatherbushido. Fixes #3830