Opened 8 years ago

Closed 8 years ago

#3843 closed defect (fixed)

Yet another broken aura ticket

Reported by: elexis Owned by: sanderd17
Priority: Release Blocker Milestone: Alpha 20
Component: UI & Simulation Keywords:
Cc: fatherbushido Patch:

Description

These aura errors occured in an SVN testgame on r17920 (should be compatible to r17926). We won it anyway. Looks like r17863.

Executing turn 4169 of 5038
WARNING: JavaScript warning: simulation/components/Auras.js line 389
reference to undefined property this[name]
ERROR: Error in timer on entity 20675, IID 70, function ProgressTimeout: TypeError: this[name] is undefined
  Auras.prototype.ApplyBonus@simulation/components/Auras.js:389:2
  Auras.prototype.ApplyGarrisonBonus@simulation/components/Auras.js:338:26
  GarrisonHolder.prototype.PerformGarrison@simulation/components/GarrisonHolder.js:279:3
  ProductionQueue.prototype.SpawnUnits@simulation/components/ProductionQueue.js:574:1
  ProductionQueue.prototype.ProgressTimeout@simulation/components/ProductionQueue.js:714:8
  Timer.prototype.OnUpdate@simulation/components/Timer.js:100:4

Executing turn 4170 of 5038
...
Executing turn 4254 of 5038
WARNING: JavaScript warning: simulation/components/Player.js line 523
reference to undefined property this.diplomacy[id]
WARNING: JavaScript warning: simulation/components/Auras.js line 414
reference to undefined property this[name]
ERROR: Script message handler OnGlobalOwnershipChanged failed
ERROR: Script message handler OnGlobalOwnershipChanged failed
ERROR: Script message handler OnGlobalOwnershipChanged failed
ERROR: Script message handler OnGlobalOwnershipChanged failed
ERROR: Script message handler OnGlobalOwnershipChanged failed
ERROR: Script message handler OnGlobalOwnershipChanged failed
ERROR: Script message handler OnGlobalOwnershipChanged failed
ERROR: Script message handler OnGlobalOwnershipChanged failed
ERROR: Script message handler OnGlobalOwnershipChanged failed
ERROR: Error in timer on entity 20554, IID 90, function TimerHandler: TypeError: this[name] is undefined
  Auras.prototype.RemoveBonus@simulation/components/Auras.js:414:2
  Auras.prototype.RemoveGarrisonBonus@simulation/components/Auras.js:365:27
  GarrisonHolder.prototype.Eject@simulation/components/GarrisonHolder.js:352:3
  GarrisonHolder.prototype.PerformEject@simulation/components/GarrisonHolder.js:412:1
  GarrisonHolder.prototype.EjectOrKill@simulation/components/GarrisonHolder.js:697:4
  GarrisonHolder.prototype.OnGlobalOwnershipChanged@simulation/components/GarrisonHolder.js:610:4
  Capturable.prototype.RegisterCapturePointsChanged@simulation/components/Capturable.js:154:2
  Capturable.prototype.Reduce@simulation/components/Capturable.js:109:2
  Attack.prototype.PerformAttack@simulation/components/Attack.js:598:1
  UnitAI.prototype.UnitFsmSpec.INDIVIDUAL.COMBAT.ATTACKING.Timer@simulation/components/UnitAI.js:1898:8
  FSM.prototype.ProcessMessage@simulation/helpers/FSM.js:274:29
  UnitAI.prototype.TimerHandler@simulation/components/UnitAI.js:3853:68
  Timer.prototype.OnUpdate@simulation/components/Timer.js:100:4

Executing turn 4255 of 5038
...
Executing turn 4302 of 5038
ERROR: Error in timer on entity 18559, IID 70, function ProgressTimeout: TypeError: this[name] is undefined
  Auras.prototype.ApplyBonus@simulation/components/Auras.js:389:2
  Auras.prototype.ApplyGarrisonBonus@simulation/components/Auras.js:338:26
  GarrisonHolder.prototype.PerformGarrison@simulation/components/GarrisonHolder.js:279:3
  ProductionQueue.prototype.SpawnUnits@simulation/components/ProductionQueue.js:574:1
  ProductionQueue.prototype.ProgressTimeout@simulation/components/ProductionQueue.js:714:8
  Timer.prototype.OnUpdate@simulation/components/Timer.js:100:4

Executing turn 4303 of 5038
...
Executing turn 4345 of 5038
ERROR: Script message handler OnGlobalOwnershipChanged failed
ERROR: Script message handler OnGlobalOwnershipChanged failed
ERROR: Script message handler OnGlobalOwnershipChanged failed
ERROR: Script message handler OnGlobalOwnershipChanged failed
ERROR: Script message handler OnGlobalOwnershipChanged failed
ERROR: Script message handler OnGlobalOwnershipChanged failed
ERROR: Script message handler OnGlobalOwnershipChanged failed
ERROR: Script message handler OnGlobalOwnershipChanged failed
ERROR: Script message handler OnGlobalOwnershipChanged failed
ERROR: Error in timer on entity 19932, IID 90, function TimerHandler: TypeError: this[name] is undefined
  Auras.prototype.RemoveBonus@simulation/components/Auras.js:414:2
  Auras.prototype.RemoveGarrisonBonus@simulation/components/Auras.js:365:27
  GarrisonHolder.prototype.Eject@simulation/components/GarrisonHolder.js:352:3
  GarrisonHolder.prototype.PerformEject@simulation/components/GarrisonHolder.js:412:1
  GarrisonHolder.prototype.EjectOrKill@simulation/components/GarrisonHolder.js:697:4
  GarrisonHolder.prototype.OnGlobalOwnershipChanged@simulation/components/GarrisonHolder.js:610:4
  Capturable.prototype.RegisterCapturePointsChanged@simulation/components/Capturable.js:154:2
  Capturable.prototype.Reduce@simulation/components/Capturable.js:109:2
  Attack.prototype.PerformAttack@simulation/components/Attack.js:598:1
  UnitAI.prototype.UnitFsmSpec.INDIVIDUAL.COMBAT.ATTACKING.Timer@simulation/components/UnitAI.js:1898:8
  FSM.prototype.ProcessMessage@simulation/helpers/FSM.js:274:29
  UnitAI.prototype.TimerHandler@simulation/components/UnitAI.js:3853:68
  Timer.prototype.OnUpdate@simulation/components/Timer.js:100:4

Executing turn 4346 of 5038

Attachments (2)

commands.txt (888.8 KB ) - added by elexis 8 years ago.
commands.2.txt (8.5 KB ) - added by sanderd17 8 years ago.

Download all attachments as: .zip

Change History (5)

by elexis, 8 years ago

Attachment: commands.txt added

by sanderd17, 8 years ago

Attachment: commands.2.txt added

comment:1 by sanderd17, 8 years ago

Above I included a shorter commands.txt to reproduce the issue.

It seems to happen when the hero is autogarrisoned.

comment:2 by fatherbushido, 8 years ago

Add this line in Init ?

 this[name] = {};

comment:3 by sanderd17, 8 years ago

Owner: set to sanderd17
Resolution: fixed
Status: newclosed

In 17931:

Completely initialise Auras even before ownership is set. Fixes #3843

Note: See TracTickets for help on using tickets.