[PATCH] Health / capture point round error

[bb]

brit, gaul and spartan woman have some round error due to the auto researched tech. Simply rounding in gui and removing roundings from sim will solve the issue.

Screenshot by _kali where a wonder has one more capture point than it should.

[sanderd17]

In 17951:

Round max hp of units in simulation. Refs #3855

[sanderd17]

Thanks to bb, we discovered some related issues to this. F.e. the current hitpoints are rounded in GuiInterface, but also in various gui pages (which wouldn't be needed).

And the max hp should probably be rounded in the same places as the current hp.

The same would also count for capture points.

The fix above was made to just modify as few code and functionality as possible (since we're close to release). But this should be investigated further.

So this ticket isn't fixed yet.

[mimo]

You have to be careful when rounding values in the simulation that the same roundings are applied in AIInterface so that the AI is consistent. We had cases in the past with the AI trying endlessly to repair a structure because it did not have the same rounding as in the simulation. There are big chances that the roundings from the patch womanhealthround.2.diff would give troubles, while r17951 should be fine as the Health/Max was already rounded when ApplyValueModificationsToEntity and in AIInterface.

[bb]

proper fix

[sanderd17]

In 18009:

Properly round health and CP values. Patch by bb. Fixes #3855