Opened 8 years ago
Last modified 4 years ago
#3883 closed defect
Persist match settings should only save some settings — at Initial Version
Reported by: | elexis | Owned by: | |
---|---|---|---|
Priority: | Must Have | Milestone: | Alpha 24 |
Component: | UI – Game setup | Keywords: | patch |
Cc: | Patch: |
Description
Currently the persist-matchsettings function (see gamesetup.js
) store all mapsettings and load it the nexttime.
But some tags shouldn't be saved.
- For example this author tag removed in r17980 was present in every replay due to this bug once the map was started once.
- Another example is
DisabledTemplates
. Belgian Uplands is the only map that disables the ptolemian lighthouse. But the persistmatchsettings will save this value and when selecting a map that doesn't set it, it actually disables them due to the remains in the persistmatchsettings-file.
Only known settings (which can be changed by the host) should be restored - every other setting ignored (notice on skirmish and scenario maps, less settings can be changed).
Note:
See TracTickets
for help on using tickets.
In order to remove unintended tags,
loadPersistMatchSettings()
ingamesetup.js
needs to delete all properties of theattrs
object which can't be changed by the user.