[PATCH] We should be able to set a trade-route with a miraged market

[mimo]

Currently, the gui does not allow to set a route with a miraged market, which is a problem when trading with neutrals, or with allies before the shared los tech. The mirage should be extended to contain the market info, and this be used by the gui when setting a route.

Once done, UnitAI should be able to use this info to take the proper action when a market is destroyed or captured.

see also some discussion in #3277

[mimo]

patch to allow making a trade route with a miraged market

[mimo]

new approach, should be more robust

[mimo]

Mirages have no obstructions, so the previous patch may not give the best path when targeting a mirage. So here a is a modified version which recomputes the path as soon as the market becomes visible when approaching to it.

[elexis]

I noticed the exact same behavior when telling units to construct a miraged foundation. They will first walk to the center of the foundation, then go back to the edge of the foundation and try to construct it. But since the other units following the first have the same behavior, the units have to wait until all units had reached the middle of the foundation, so there is quite a delay. Notice this happens when issuing a repair command, but not when issuing a build command.

[mimo]

r18145 has fixed the obstruction problems of mirages, so the hack in version 2.1 is no more needed and the right patch is marketVisibility-v2.patch

[mimo]

I've just uploaded v3 which improves the UnitAI behaviour. When a market is destroyed or captured, the trader returns back to the other market if the lost one is visible, otherwise it continues its route up to the point where the market would have been visible and then returns back.

[elexis]

Syntax check only:

• cmpTrader ? cmpTrader.GetFirstMarket() : undefined -> cmpTrader && cmpTrader.GetFirstMarket()
• duplicate parenthesis (msg.to == -1)

unneeded parenthesis (!cmpTrader.HasMarket(this.entity) || (!onDestruction && cmpTrader.CanTrade(this.entity))) as && has a higher operator precedence than

(like * and +)

[mimo]

with fixes of elexis comments

[mimo]

In 18172:

allow trade with mirage markets, fixes #3894