[PATCH] In gamesetup: Use a hotkey to start the game or get ready

[Imarok]

It would be usefull to use Enter key when in gamesetup to start the game or get ready

[elexis]

More useful than focusing the chat when entering the multiplayergamesetup? ​http://trac.wildfiregames.com/browser/ps/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js#L263

[Imarok]

Good question But it would be usefull when the chat isn't focused and when you play singleplayer.

Maybe just start focus the chat when some key != enter is pressed and forward this key to the chat input box. (Could be difficult to implement ;) )

[Imarok]

defines a hotkey for start game or be ready in the gamesetup

[elexis]

• Doesn't actually work for me, neither in singleplayer nor in multiplayer.
• wrong indentation in the xml
• in that xml function, you can return if not enabled, and then use one simple if-else without braces
• (The credits part was committed before)
• For multiplayer the chat is focused on join, so if that isn't changed, the feature doesn't make sense for multiplayer.
• I'm not sure if this feature is needed at all. How often did you join multiplayermatches and didn't care about any of the settings? Usually people have to talk things through, thus are required to focus the chat (thus are required to click the button). If you are serious about this, come to IRC and convince mimo, leper, fatherbushido or sanderd17 ;)

I agree though that it would be nice to have a system to control the GUI solely with the keyboard (ticket somewhere). Just the enter key seems a bad choice if we don't have a way to change focus from the keyboard.

[Imarok]

Replying to elexis:

• Doesn't actually work for me, neither in singleplayer nor in multiplayer.

Hmm :( It worked for me :D

I agree though that it would be nice to have a system to control the GUI solely with the keyboard (ticket somewhere). Just the enter key seems a bad choice if we don't have a way to change focus from the keyboard.

I just took a random key ;) But it is difficult to find a key that is not needed for the chat (If you have ideas...)

[Imarok]

Maybe the Pause key ;)

[Imarok]

Now uses the "F1" key

[Imarok]

Also rewrote it. Should work now.

[elexis]

Actually that's quite nice to have that hotkey.

• How about showing the hotkey in the tooltip of the button (like the hotkeys for queueing units in the selection panel)
• Is that the only useful hotkey for gamesetup or shouldn't we add all of them that we can identify? (Maybe with #3806)

[Imarok]

Replying to elexis:

• Is that the only useful hotkey for gamesetup or shouldn't we add all of them that we can identify? (Maybe with #3806)

What has this to do with #3806?

[sanderd17]

F1 is a quite standard key in most programs to get some sort of "help" functionality. I don't think we should use F1 for something else.

[elexis]

Replying to sanderd17:

F1 is a quite standard key in most programs to get some sort of "help" functionality. I don't think we should use F1 for something else.

Kind of true, but looking at my keyboard, there aren't too many choices that make sense. The next unused hotkey would be F3. :D (Also I keycombis with modifier keys like Alt should probably be avoided, so we can't use R).

Replying to Imarok:

What has this to do with #3806?

As intended by that ticket there will be more controllers of the game in the feature. Thus we might think about adding hotkeys for controlling the GUI objects. But it seems #3235 would be a better and more universal solution for that.

---

Also I think if we have such a hotkey, it would be great if it worked also when the chat is focused and focus the previously focused thing again after activation (or not change the focus at all).

[Imarok]

removed until hotkey works even if chat is focussed.

[elexis]

This might actually impossible to implement, since hotkeys are supposed to be disabled when a text element is focused. Otherwise one wouldn't be able to type chat in games without doing all kinds of unintended actions. (For the same reason the autocomplete tab hotkey is hardcoded in cpp files).

It seems unlikely that the ready hotkey will be used if it won't work if the chat is focused, since that chat is focused by default and since most people will use the chat before starting the game.

[Imarok]

Move tickets to Game Setup as UI & Simulation got some sub components.