#3909 closed defect (fixed)
[PATCH] Rename TechnologyTemplateManager to JsonTemplateManager — at Version 4
Reported by: | sanderd17 | Owned by: | sanderd17 |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 21 |
Component: | UI & Simulation | Keywords: | patch |
Cc: | Patch: |
Description (last modified by )
Since the TechnologyTemplateManager
doesn't only do techs anymore, it should be renamed to something more generic, like JsonTemplateManager
.
Note: this also disables serialization of the cached tech data (refs #3834 )
Due to the difficulty of renaming files and creating diffs of those, I've included two patches. They're the same with the exception that one has renamed files and the other one doesn't.
Change History (6)
by , 8 years ago
Attachment: | renameTechMan.diff added |
---|
by , 8 years ago
Attachment: | renameTechManNoFile.diff added |
---|
comment:1 by , 8 years ago
comment:2 by , 8 years ago
Keywords: | review removed |
---|
I agree with the naming CCmpDataTemplateManager
.
Why do you change the function name in TechnologyManager
? After all it is still the technology manager so GetTechnologyTemplate
is not an inaccurate name.
comment:4 by , 6 years ago
Description: | modified (diff) |
---|
Since it wasn't linked here yet, it was broken because the Auras and TechnologyManager components still serialized the objects from the DataTemplateManager
, thus yielding different backrefs for rejoined clients, thus OOS deluxe (not even visible in the textual dump diff), see #4239.
The component should be a globalscript
, so that it can be used by the AI, GUI and rmgen as well.
I initially agreed with JSONTemplateManager so that we immediately know how its different from the TemplateManager. But even better would be splitting the file into an Aura and a Technology file.
Note from leper: jsonTemplateManager isn't a good name either (data can contain any data format). Better is something like dataTemplateManager.