[PATCH] Sheep in summary screen

[elexis]

The total unit number in the summary screen includes animals, so it is not possible to find out how many females or humans a player owns.

Since everyone looks at the total number of units to estimate the strength of an economy of a player, animals should not be included there.

They could be listed in a another column. This will fit 1280x1024. For 1024x768 the current amount of columns already doesn't fit, so adding one more (with less relevant stats like this one) might be okay, especially since there will be scrolling sometime.

[elexis]

Don't forget to add yourself to programming.json and update the ticket with the review keyword an milestone.

[fatherbushido]

• In counters.js, you can remove the { } and the else.

• It's a bit strange to have "trained/killed/lost" for animals. What do you want in killed and lost ?

• Moreover (it depends on 2) perhaps you should use Domestic instead of Animal.

Thx for working on that.

(NB: for who wants to test it, apply the patch with patch -p1)

[sanderd17]

If animals get their own category, they could be included in the total IMO.

It should be doable for a player to estimate the total number of humans when you have the overall total, and the number of animals.

It's rather strange to have a total column that isn't the total of all categories listed IMO.

So either the entire stat count should only consider units (and not have a column for sheep), sheep would belong more in the "resources" pane in that case. Or there can be a column for sheep, and then it should be included in the total too.

[fatherbushido]

Indeed it makes more sense to add them in "resources" pane.

[elexis]

Replying to sanderd17:

If animals get their own category, they could be included in the total IMO. It's rather strange to have a total column that isn't the total of all categories listed IMO.

Agree.

Replying to fatherbushido:

Indeed it makes more sense to add them in "resources" pane.

Disagree, animals are not resources.

[Jon Baer]

Actually this patch needs more work as it misses the War Dog. If I understand this correctly there are 2 "Animals" in this case, the ones which are trained to be part of a unit (ie the War Dog, Elephants) and ones which are trained for resource (Sheep, Pigs, etc) and in one case the totals would make sense since they would be lost/killed, the other should really be counted w/ food. This is my first attempt @ a patch so bear with me but I understand the issue, that really a unit total shouldn't count those sheep which were "trained".

[fatherbushido]

(Neither War Dog nor the Elephants (champs, archers or support) are Animal)

[elexis]

Replying to fatherbushido:

(Neither War Dog nor the Elephants (champs or archers) are Animal)

...nor should they become that. The summary screen should only show huntable/economic animals produced by the player, as in those that have the Animal tag only.

[Jon Baer]

Understood, just realized I should have included screenshots for those who don't have time to apply the patch. What I could do for now is keep the total deduction of the sheep but move the stat to Misc tab(?), this is a good ticket because it gives me familiarity w/ both the GUI and statistics.

On the Units tab - if you raise War Dogs they show up in the total but not in the breakdown, such as the corral animals.

I'm trying to think of what a good stat(s) the corral could give, like % of food which came from domestic raising, etc. For now can give just a total number raised I think.

One question I have re: development is at which stages does the translate(string) get done? I read the document on i18n but are the translations usually submitted w/ the functionality patch as well?

[fatherbushido]

@jonbaer: You did the translation stuff with translate in layout.js. I will push the patch out of the review queue waiting the next version. Thx for keeping working on it.

[causative]

IMO these "Animals" should be displayed on the summary screen as "Livestock" to eliminate any confusion with war dogs or worker elephants.

[elexis]

Also as pointed out by causative, calculateEconomyScore should at least get a comment that it takes the vegetarianFood into account twice.

Furthermore it were nice if the resource supply of sheep were listed in the tech tree as well.

[Imarok]

Plan is to add sheeps, goats etc. as Livestock to the resource panel and don't count it to the total units.