Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3954 closed defect (fixed)

[PATCH] some inconsistencies in templates for gauls infantry and pers trirem units

Reported by: fatherbushido Owned by: mimo
Priority: Should Have Milestone: Alpha 21
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description (last modified by fatherbushido)

Sorry for posting that kind of obvious ticket.

  • In r13381, gauls infantry basic unit Armour staied hardcoded (they were forgotten). It currently gives inconsistencies (gauls spearmen have 1 armour instead of 5 for other spearmen and gauls ranged unit have 2 armour instead of 1 for others). Thanks to Siole, wang_wei and other svn players for noticing that.
  • Attack, Health and Armour are hardcoded for advanced and elite persian trirem units. It gives some fun fact. The basic swordcav have 6,5 Hack Attack and 15 Crush Armour, and the advanced one have 24,6 Hack Attack and 6 Crush Armour, then the elite one have 41,3 Hack Attack :)

Attachments (3)

3954.diff (5.9 KB ) - added by fatherbushido 8 years ago.
3954_gauls.diff (1.9 KB ) - added by fatherbushido 8 years ago.
3954_pers_trirem.diff (4.4 KB ) - added by fatherbushido 8 years ago.

Download all attachments as: .zip

Change History (7)

by fatherbushido, 8 years ago

Attachment: 3954.diff added

comment:1 by fatherbushido, 8 years ago

Description: modified (diff)

comment:2 by fatherbushido, 8 years ago

Description: modified (diff)

by fatherbushido, 8 years ago

Attachment: 3954_gauls.diff added

by fatherbushido, 8 years ago

Attachment: 3954_pers_trirem.diff added

comment:3 by mimo, 8 years ago

Owner: set to mimo
Resolution: fixed
Status: newclosed

In 18134:

remove hardcoded inconsistencies in some templates, fixes #3954, patch by fatherbushido

comment:4 by mimo, 8 years ago

Keywords: review removed

Thanks for the patch

Note: See TracTickets for help on using tickets.