Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4016 closed defect (fixed)

[PATCH] Merge duplicate theatron templates

Reported by: elexis Owned by: elexis
Priority: Should Have Milestone: Alpha 21
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description (last modified by Palaxin)

The templates for the theatron are duplicated and should just use a parent template.

Code duplication results in one of the copies not being updated when changing things (and has already happened to that and many other files, for example ConquestCritical wasn't updated in theb_theatron).

This might be the case with other templates too and should be checked.

Refs #4021, #4022

Attachments (3)

theatron.diff (10.6 KB ) - added by fatherbushido 8 years ago.
theatron.2.diff (10.6 KB ) - added by fatherbushido 8 years ago.
or this one with the same sound for the theb one too
theatron.3.diff (10.5 KB ) - added by fatherbushido 8 years ago.
nuke the theb_theatron template as it is used nowhere

Download all attachments as: .zip

Change History (8)

by fatherbushido, 8 years ago

Attachment: theatron.diff added

by fatherbushido, 8 years ago

Attachment: theatron.2.diff added

or this one with the same sound for the theb one too

by fatherbushido, 8 years ago

Attachment: theatron.3.diff added

nuke the theb_theatron template as it is used nowhere

comment:1 by fatherbushido, 8 years ago

Keywords: patch review added
Summary: Merge duplicate theatron templates[PATCH] Merge duplicate theatron templates

comment:2 by elexis, 8 years ago

Owner: set to elexis
Resolution: fixed
Status: newclosed

In 18269:

Template cleanup. Patch by fatherbushido, fixes #4016.

Removes duplicate theatron templates and use a parent template instead.
Removes unused Theban theatron.
Fixes a buildtime inconsistency.
Also improve the tooltip string as suggested by leper.

comment:3 by elexis, 8 years ago

Keywords: simple review removed
Milestone: BacklogAlpha 21

Thanks, keep it up!

comment:4 by elexis, 8 years ago

In 18270:

Actually delete it, refs #4016.

comment:5 by Palaxin, 8 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.