#404 closed defect (fixed)
Makefile build system should have pyrogenesis/test targets depend on Collada — at Version 15
Reported by: | Philip Taylor | Owned by: | Itms |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 23 |
Component: | Build & Packages | Keywords: | |
Cc: | Patch: |
Description (last modified by )
The Collada
target is a run-time dependency for pyrogenesis
and test
, so it ought to get built automatically when people run make pyrogenesis
and make test
. Currently it doesn't.
It's not a build-time dependency for the executables, and shouldn't be used when linking, so Premake's package.links
does not seem to be a suitable place to put it. Is there another way? or maybe Premake needs to be patched to support non-linking dependencies?
Change History (16)
comment:1 by , 14 years ago
Milestone: | Open Source Release |
---|
comment:2 by , 14 years ago
Milestone: | → Backlog |
---|
comment:3 by , 11 years ago
Component: | Core engine → Build & Packages |
---|
by , 11 years ago
Add "deps" option to premake projects. Also beef up .gitignore a little.
comment:4 by , 11 years ago
A bit of searching around turned up this feature request for premake: http://sourceforge.net/p/premake/feature-requests/148/
So premake does need to be patched for this. Checking their dev repository just now, I see that a similar feature is already there, so you may want to use that instead. (https://bitbucket.org/premake/premake-dev/src/5c0c8d6a5254378d49aa6eb7e2b9effc3a6e38c1/src/base/project.lua?at=default#cl-211)
comment:5 by , 11 years ago
Keywords: | patch review added |
---|---|
Milestone: | Backlog → Alpha 15 |
Summary: | Makefile build system should have pyrogenesis/test targets depend on Collada → [PATCH] Makefile build system should have pyrogenesis/test targets depend on Collada |
comment:6 by , 10 years ago
Milestone: | Alpha 15 → Alpha 16 |
---|
comment:7 by , 10 years ago
Milestone: | Alpha 16 → Alpha 17 |
---|
comment:8 by , 10 years ago
Milestone: | Alpha 17 → Alpha 18 |
---|
comment:9 by , 9 years ago
Milestone: | Alpha 18 → Alpha 19 |
---|
The patch doesn't look too bad, making the variable naming and premake function a bit closer to upstream would be nice (also regarding #1518). But as we are currently in feature freeze I'll push this to A19 and take a closer look at it then.
comment:10 by , 9 years ago
Milestone: | Alpha 19 → Alpha 20 |
---|
comment:11 by , 8 years ago
Milestone: | Alpha 20 → Alpha 21 |
---|
comment:12 by , 8 years ago
Keywords: | simple review removed |
---|---|
Milestone: | Alpha 21 → Backlog |
This should wait for #3729.
comment:13 by , 7 years ago
Keywords: | patch removed |
---|---|
Milestone: | Backlog → Work In Progress |
Summary: | [PATCH] Makefile build system should have pyrogenesis/test targets depend on Collada → Makefile build system should have pyrogenesis/test targets depend on Collada |
A fix is included to the patch at #3729, and it will be effective as soon as premake5 becomes the default.
comment:15 by , 7 years ago
Description: | modified (diff) |
---|---|
Milestone: | Work In Progress → Alpha 23 |
Milestone Open Source Release deleted