[PATCH] Dahae horse archer stops attack animation

[elexis]

If you train a seleucid dahae horse archer at the barracks and attack something, it will show the attack animation once but then stops (while still shooting arrows).

Might have observed that on another cavalry unit too, but not sure. (I hope it will be easy enough to notice when reading the files).

[sanderd17]

Investigation of the issue: this happens since animation inheritance between props has been altered, so the main actor can choose to name its animations differently, and then the animation should be inherited by the props.

As the main actor here doesn't have an "attack_ranged" animation, it should default to "idle", and rider (which is a prop) should also inherit the "idle" animation to stay in sync.

However, it appears that the rider goes through one "attack_ranged" animation cycle, before switching to "idle". This probably points to a bug in the code somewhere.

[elexis]

Mauryan swordswomen champions have neither attack nor capture animation.

[Lionkanzen]

Roman spearman cavalry, spearman infantry Roman and Celt. Cavalry animation for recollecting food by hunt and domestic stop or can't complete the animation loop. Or even have a variance.

[Lionkanzen]

I can record a video if is required.

[elexis]

Sorry for the false alert, the charge thing was fixed by r18481.

However the gathering animation still stops. I could reproduce it by producing a cavalry, promoting it twice and then gathering. It plays the animation like 5 times and then remains in idle animation until the gathering was completed. It seems like it would uses the time of the unpromoted template while the promoted one requires more time.

[elexis]

Persian chariots also stopping the attack animation after shooting one arrow, so likely a bug in the cavalry archer file.

[sanderd17]

The patch above should fix the original issue. If any issue described in the comments still exists, that should have a different cause and desirve a separate ticket.

Note that there's also a small code style improvement.

[sanderd17]

Elexis did the first test and approved, so I'm pushing it to the review queue.

[sanderd17]

In 18568:

Don't let the props inherit the 'idle' animation if the parent doesn't have the needed animation. Fixes #4071