[PATCH] Use exception strings instead of LOGERROR in (de)serializer

[Philip Taylor]

In some cases the serialization code uses LOGERROR then throws an exception. Now that exceptions can contain message strings, the code should simply throw the exception and not log it explicitly, to simplify the code a little.

[(none)]

Milestone Unclassified deleted

[historic_bruno]

I believe this is mostly fixed, with a handful of cases in BinzarySerializer.cpp remaining.

[Markus]

The remainding errors in BinarySerializer.cpp ​have dynamic messages which cannot be thrown so easy with the current error class.

Either modify the error class so it creates a local copy of the string or use a static string buffer.

Any reason PSERROR inherits from std::exception and not from std::runtime_error? (That one would have its own string copy and what is also implemented.)

[historic_bruno]

I don't know why PSERROR was implemented that way, jan or Philip would know, maybe it was personal preference, but I do know it has annoyed me for a long time that it only accepts a temp C-string.

[Jan Wassenberg]

Sure, why not change to to runtime_error. I don't know why it isn't already.

[Markus]

We now could add two interfaces to allow simple composing:

• Adding a constructor with variable argument list (like printf).

  throw SomeException("Error: %i", errno);
  

• Adding a stringsstream to allow C++ like formatting.

  throw SomeException() << "Error: " << errno;
  

I favor the latter as the compile knows best what type the variables (e.g. errno) have.

(Or none of them, the exception just takes one simple string.)

[Markus]

Needs some testing with different compilers as well.

Added a small test case. (Any additional test cases?)

[historic_bruno]

Not sure I care for the stringstream approach, it looks very strange compared to how we handle errors and strings in most of the engine :/ The printf style for better or worse is more conventional in the engine.

[Imarok]

Move tickets to Simulation as UI & Simulation got some sub components.