[PATCH] Round instead of ceil/floor in the GUI

[elexis]

There are some rounding issues in the GUI:

• Trade carts can have very poor income, like 3 per trip. Since resources are floats however, the +10% upgrade might be actually useful in such a situation. So maybe the selection details could show two digits if the income is < 10.
• Some Hellenic buildings show +1HP due to some ceil(xxx.00002) (f.e. civic center 3301HP, house 1201HP, outpost 881HP, wooden tower 881CP).
• The ceil call for healthpoints was added so that there couldn't be a unit shown with "0" health points. So maybe we should use a round(HP) || 1 to account for that (r18009).

It seems floor/ceil should be abandoned altogether, but that needs to be investigated thoroughly considering the described edge case.

[elexis]

Missing rounds likely introduced in r18500:

• The translate("%(resourceIcon)s %(minimum)s to %(resourceIcon)s %(maximum)s") part of the wall-tooltip in tooltips.js isn't rounded at all and might show many digits.

• The summary screen doesn't use any rounding at all. Thanks echotangoecho for discovering and reporting:

The attached patch doesn't address the summary screen yet and it will have to be added in basically all places there.

[elexis]

Adding simple for anyone who wants to add round to all those places in the summary screen.

[Sandarac]

In the summary screen, this only seems to be an obvious issue when calculating Resources Used. I didn't add Round to stats like "Units Trained".

[fatherbushido]

I tested it and push it in the review queue.

[fatherbushido]

see ​http://trac.wildfiregames.com/ticket/3818#comment:10 for the resources cost part putting it in rfc back as there is still discussion about that

[fatherbushido]

For the resources cost:

• r18500 reverted in r18632
• there are imo missing roundings just after the tech modifications (so the same rounding should occur too in Templates.js) and then we won't need any rounding in the gui (as Cost/Resources are integers).

See for example: ​http://trac.wildfiregames.com/attachment/ticket/3818/costroundinthesim.diff But in this case, we should take care of roundings in Petra (the above patch is probably wrong for that).

[fatherbushido]

Another thing : wall has in gui 3001 / 3001 hp (sic). When upgrading it to a gate, we got in gui 3000 / 30001 hp.

[elexis]

Moving to the new WIP milestone.

[fatherbushido]

I guess comments have been said. I remove rfc.

[fatherbushido]

Replying to fatherbushido:

Another thing : wall has in gui 3001 / 3001 hp (sic). When upgrading it to a gate, we got in gui 3000 / 30001 hp.

It was a simulation bug and not a gui one (repairer and healer immediatly try to repair or heal). refs: r19994, r19995, r19996