Opened 4 years ago

Closed 4 years ago

#4167 closed enhancement (fixed)

[PATCH] Colorize selected units in observermode

Reported by: elexis Owned by: Imarok
Priority: Should Have Milestone: Alpha 22
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

If a client is in observermode all units become selectable. Thus it is not possible to distinguish which units are owned by which player (especially if they have the identical unit type).

The selection panel should show which units are owned by which player by (1) grouping the units by playerID (2) adding a border in the playercolor (same as in r18362)

Change History (12)

comment:1 by Imarok, 4 years ago

what should happen when the observer selects two same units from different players? (e.g. one athenian Woman from player A and one from player B) atm they are counted as same in the selection.

comment:2 by elexis, 4 years ago

That's the purpose of this ticket - they should be split by both player ID and unit type. It is only relevant to observers since players can only select their own units or one non-owned. For a use case, imagine a 1v1 where both players fight with sword champions of the same civ. If it's split you will be able to determine the unit numbers easily while currently you only get the sum.

comment:3 by Imarok, 4 years ago

Keywords: patch rfc added
Milestone: BacklogAlpha 22
Summary: Colorize selected units in observermode[PATCH] Colorize selected units in observermode

comment:4 by elexis, 4 years ago

Keywords: review added; rfc removed

Patch seems to work. I see your "ugly" point you had raised earlier, perhaps we should recude the size of the border (if that's even possible easily)?

comment:5 by elexis, 4 years ago

Keywords: simple review removed

Nope, still a bug - doubleclicking on some units like trade carts selects none of them.

comment:6 by Imarok, 4 years ago

Keywords: review added

Fixed

comment:7 by Imarok, 4 years ago

Owner: set to Imarok
Resolution: fixed
Status: newclosed

In 18979:

Colorize selected units in observermode, reviewed by elexis, fixes #4167

comment:8 by Imarok, 4 years ago

Keywords: review removed

comment:9 by elexis, 4 years ago

Thanks for the patch, it is a very important one in the area of smaller observermode improvements.

comment:10 by elexis, 4 years ago

Resolution: fixed
Status: closedreopened

Refs #4425

comment:11 by Imarok, 4 years ago

In 19202:

Properly sort selected entities by owner

Fixes #4425. Refs #1807, #4167. Fixes rP18979

Reviewed by: mimo

Differential Revision: https://code.wildfiregames.com/D123

comment:12 by Imarok, 4 years ago

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.