[PATCH] Colorize selected units in observermode

[elexis]

If a client is in observermode all units become selectable. Thus it is not possible to distinguish which units are owned by which player (especially if they have the identical unit type).

The selection panel should show which units are owned by which player by (1) grouping the units by playerID (2) adding a border in the playercolor (same as in r18362)

[Imarok]

what should happen when the observer selects two same units from different players? (e.g. one athenian Woman from player A and one from player B) atm they are counted as same in the selection.

[elexis]

That's the purpose of this ticket - they should be split by both player ID and unit type. It is only relevant to observers since players can only select their own units or one non-owned. For a use case, imagine a 1v1 where both players fight with sword champions of the same civ. If it's split you will be able to determine the unit numbers easily while currently you only get the sum.

[Imarok]

​https://github.com/Imarok/0ad/tree/4167_colorize_selection

[elexis]

Patch seems to work. I see your "ugly" point you had raised earlier, perhaps we should recude the size of the border (if that's even possible easily)?

[elexis]

Nope, still a bug - doubleclicking on some units like trade carts selects none of them.

[Imarok]

Fixed

[Imarok]

In 18979:

Colorize selected units in observermode, reviewed by elexis, fixes #4167

[elexis]

Thanks for the patch, it is a very important one in the area of smaller observermode improvements.

[elexis]

Refs #4425

[Imarok]

In 19202:

Properly sort selected entities by owner

Fixes #4425. Refs #1807, #4167. Fixes rP18979

Reviewed by: mimo

Differential Revision: ​https://code.wildfiregames.com/D123