Opened 8 years ago

Last modified 3 years ago

#4170 new defect

Mercenary camp (egyptian) and Nile map issues

Reported by: fatherbushido Owned by:
Priority: Should Have Milestone: Backlog
Component: Simulation Keywords: patch, simple
Cc: Patch:

Description (last modified by fatherbushido)

I noticed some inconsistencies and issues:

  • structures/merc_camp_egyptian and structures/ptol/mercenary_camp are almost duplicated. The first templates is used in Nile skirmish map and the other one is used nowhere.
  • The actors are structures/mercenaries/camp_egyptian.xml and structures/ptolemies/settlement.xml. Those two actor templates are almost duplicated. Take care that structures/ptolemies/settlement.xml is used by structures/sele_military_colony in game structure template.
  • That merc_camp_egyptian is currently used in Nile skirmish map. It is a gaia building that player can capture. It is aimed that player can so train some egyptian(ptolemies) mercenaries. Currently, if we use {civ} in the production queue, we will train in fact the player civ units. If we don't use {civ} then we'll train egyptian mercenaries and so will access to their buildings (and due to barracks inheritence, player civ units are also trainable in this camp).
  • moreover, in this structure we can research some old unused techs (which was forgotten i guess).

Suggested solutions:

  • nukes one of those two structure templates (and do the ad hoc modifications)
  • nukes one of those two actor templates (and do the ad hoc modifications)
  • the easier is to remove those camp from the game. Another solution is to let player train his units like it is now or perhaps remove the production queue but then it doesn't fit with that structure tooltip. There are other solutions.

Attachments (1)

mercenarycamp.diff (2.2 KB ) - added by fatherbushido 8 years ago.
draft

Download all attachments as: .zip

Change History (12)

by fatherbushido, 8 years ago

Attachment: mercenarycamp.diff added

draft

comment:1 by fatherbushido, 8 years ago

The attached patch fixes the issue. But I would like to have some comments.

  • Should we nuke structures/ptol/mercenary_camp ? (as it's used nowhere and it's a duplicate of structures/merc_camp_egyptian or perhaps keep the first name wich is perhaps better named ?)
  • The name and specific name should be check and merged / nuked / cleaned.

comment:2 by fatherbushido, 8 years ago

Keywords: patch rfc added

comment:3 by elexis, 8 years ago

Keywords: rfc removed
Milestone: Alpha 21Backlog
  • Nuke'm. Delete the one that is less consistent. The attached patch doesn't delete 2 files, so it's wrong.

comment:4 by elexis, 8 years ago

Keywords: simple added

comment:5 by fatherbushido, 8 years ago

In 18778:

Removes old depreciated technologies from production queue of atlas only (or skirmish map) structures. Refs #4170.

comment:6 by fatherbushido, 7 years ago

Description: modified (diff)

comment:7 by fatherbushido, 7 years ago

Description: modified (diff)

comment:8 by fatherbushido, 7 years ago

Description: modified (diff)

(also the units production queue fits on two lines currently)

comment:9 by Imarok, 5 years ago

Component: UI & SimulationSimulation

Move tickets to Simulation as UI & Simulation got some sub components.

comment:10 by Silier, 3 years ago

Keywords: simple removed
severity: simple

comment:11 by Silier, 3 years ago

Keywords: simple added
Note: See TracTickets for help on using tickets.