Opened 8 years ago
Last modified 3 years ago
#4170 new defect
Mercenary camp (egyptian) and Nile map issues
Reported by: | fatherbushido | Owned by: | |
---|---|---|---|
Priority: | Should Have | Milestone: | Backlog |
Component: | Simulation | Keywords: | patch, simple |
Cc: | Patch: |
Description (last modified by )
I noticed some inconsistencies and issues:
structures/merc_camp_egyptian
andstructures/ptol/mercenary_camp
are almost duplicated. The first templates is used in Nile skirmish map and the other one is used nowhere.- The actors are
structures/mercenaries/camp_egyptian.xml
andstructures/ptolemies/settlement.xml
. Those two actor templates are almost duplicated.Take care thatstructures/ptolemies/settlement.xml
is used bystructures/sele_military_colony
in game structure template. - That
merc_camp_egyptian
is currently used in Nile skirmish map. It is a gaia building that player can capture. It is aimed that player can so train some egyptian(ptolemies) mercenaries. Currently, if we use {civ} in the production queue, we will train in fact the player civ units. If we don't use {civ} then we'll train egyptian mercenaries and so will access to their buildings (and due to barracks inheritence, player civ units are also trainable in this camp). moreover, in this structure we can research some old unused techs (which was forgotten i guess).
Suggested solutions:
- nukes one of those two structure templates (and do the ad hoc modifications)
- nukes one of those two actor templates (and do the ad hoc modifications)
- the easier is to remove those camp from the game. Another solution is to let player train his units like it is now or perhaps remove the production queue but then it doesn't fit with that structure tooltip. There are other solutions.
Attachments (1)
Change History (12)
by , 8 years ago
Attachment: | mercenarycamp.diff added |
---|
comment:1 by , 8 years ago
The attached patch fixes the issue. But I would like to have some comments.
- Should we nuke structures/ptol/mercenary_camp ? (as it's used nowhere and it's a duplicate of structures/merc_camp_egyptian or perhaps keep the first name wich is perhaps better named ?)
- The name and specific name should be check and merged / nuked / cleaned.
comment:2 by , 8 years ago
Keywords: | patch rfc added |
---|
comment:3 by , 8 years ago
Keywords: | rfc removed |
---|---|
Milestone: | Alpha 21 → Backlog |
- Nuke'm. Delete the one that is less consistent. The attached patch doesn't delete 2 files, so it's wrong.
comment:4 by , 8 years ago
Keywords: | simple added |
---|
comment:6 by , 7 years ago
Description: | modified (diff) |
---|
comment:7 by , 7 years ago
Description: | modified (diff) |
---|
comment:8 by , 7 years ago
Description: | modified (diff) |
---|
(also the units production queue fits on two lines currently)
comment:9 by , 5 years ago
Component: | UI & Simulation → Simulation |
---|
Move tickets to Simulation
as UI & Simulation
got some sub components.
comment:10 by , 3 years ago
Keywords: | simple removed |
---|---|
severity: | → simple |
comment:11 by , 3 years ago
Keywords: | simple added |
---|
Note:
See TracTickets
for help on using tickets.
draft