#4292 closed task (fixed)
[PATCH] Remove deprecated water parameters
| Reported by: | Imarok | Owned by: | Imarok |
|---|---|---|---|
| Priority: | Should Have | Milestone: | Alpha 22 |
| Component: | Maps | Keywords: | patch |
| Cc: | Patch: |
Description (last modified by )
As stated here: https://github.com/0ad/0ad/blob/3bf098b1bf47e313c0d2bd952812cc365fd9ec93/source/graphics/MapReader.cpp#L752 the parameters LightingModel, Shininess, ReflectionTint and ReflectionTintStrength are deprecated. So they should be removed together with all their occurences.
Attachments (3)
Change History (10)
by , 7 years ago
| Attachment: | remove_deprecated_water_parameters.patch added |
|---|
comment:1 by , 7 years ago
| Keywords: | patch added |
|---|
comment:2 by , 7 years ago
| Keywords: | review added; simple removed |
|---|---|
| Milestone: | Backlog → Work In Progress |
Looks promising!
comment:3 by , 7 years ago
| Summary: | Remove deprecated water parameters → [PATCH] Remove deprecated water parameters |
|---|
comment:4 by , 7 years ago
In the credits the order should be consistent: First nickname, then realname.
I couldn't find any occurrences in the map folder. I tested several maps and didn't find any error. I looked into some files likely to have related stuff that might nor show up in stringsearch like rmgen environment and randombiome stuff but all seems fine. Changes in MapReader look good to me but I'm not very familiar with the renderer.
Thanks paulobezerr for the patch!
by , 7 years ago
| Attachment: | remove_deprecated_water_parameters2016_12_3.patch added |
|---|
Swapped credit name order
by , 7 years ago
| Attachment: | remove_deprecated_water_parameters2016_12_3.2.patch added |
|---|
Swapped credit name order
comment:7 by , 7 years ago
| Description: | modified (diff) |
|---|---|
| Keywords: | review removed |
| Milestone: | Work In Progress → Alpha 22 |
The deprecated settings were discovered following #4288. Thanks for the ticket, complete patch and reviews!
remove_deprecated_water_parameters.patch