Opened 8 years ago

Last modified 3 years ago

#4313 new defect

[PATCH] Map preview image for players who don't have the selected map

Reported by: elexis Owned by:
Priority: Should Have Milestone: Backlog
Component: UI – Game setup Keywords: patch, simple
Cc: Patch:

Description

In alpha 20 and previous versions, there was a clientside error when the host selected a map that the client didn't have. Furthermore the presented mappreview area was entirely magenta.

Attachments (1)

no_mappreview_WIP_v0.1.patch (4.7 KB ) - added by elexis 8 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 by elexis, 8 years ago

r18614 attempted to solve this by checking whether the file exists and otherwise picking the default mappreview image.

However that approach only works for clients that have access to PNG files. The released versions on the other side only come with DDS files.

The sprite = foo.png part still works if there are only DDS files available, but the FileExists call does not translate the PNG to DDS, thus always displays the default map preview image to clients with the released version.

comment:2 by elexis, 8 years ago

In 18905:

Revert r18614 as it doesn't work with the packaged version, refs #4313, because that comes with DDS files instead of PNGs and FileExists does not translate that like the sprite attribute does.

by elexis, 8 years ago

comment:3 by elexis, 8 years ago

Milestone: Alpha 21Alpha 22

Patch doesn't compile yet, but I'd like to hear whether the approach is entirely stupid.

comment:4 by Imarok, 8 years ago

Probably should be sovled, be adding a new gui attribute named sprite_fallback, that gets displayed, when the sprite defined in the property sprite doesn't exist.

comment:5 by elexis, 8 years ago

Keywords: rfc removed
Milestone: Alpha 22Backlog
Summary: Map preview image for players who don't have the selected map[PATCH] Map preview image for players who don't have the selected map

comment:6 by Imarok, 5 years ago

Component: UI & SimulationGame setup

Move tickets to Game Setup as UI & Simulation got some sub components.

comment:7 by Silier, 3 years ago

Keywords: simple removed
severity: simple

comment:8 by Silier, 3 years ago

Keywords: simple added
Note: See TracTickets for help on using tickets.