Opened 8 years ago
Last modified 3 years ago
#4313 new defect
[PATCH] Map preview image for players who don't have the selected map
Reported by: | elexis | Owned by: | |
---|---|---|---|
Priority: | Should Have | Milestone: | Backlog |
Component: | UI – Game setup | Keywords: | patch, simple |
Cc: | Patch: |
Description
In alpha 20 and previous versions, there was a clientside error when the host selected a map that the client didn't have. Furthermore the presented mappreview area was entirely magenta.
Attachments (1)
Change History (9)
comment:1 by , 8 years ago
by , 8 years ago
Attachment: | no_mappreview_WIP_v0.1.patch added |
---|
comment:3 by , 8 years ago
Milestone: | Alpha 21 → Alpha 22 |
---|
Patch doesn't compile yet, but I'd like to hear whether the approach is entirely stupid.
comment:4 by , 8 years ago
Probably should be sovled, be adding a new gui attribute named sprite_fallback, that gets displayed, when the sprite defined in the property sprite doesn't exist.
comment:5 by , 8 years ago
Keywords: | rfc removed |
---|---|
Milestone: | Alpha 22 → Backlog |
Summary: | Map preview image for players who don't have the selected map → [PATCH] Map preview image for players who don't have the selected map |
comment:6 by , 5 years ago
Component: | UI & Simulation → Game setup |
---|
Move tickets to Game Setup
as UI & Simulation
got some sub components.
comment:7 by , 3 years ago
Keywords: | simple removed |
---|---|
severity: | → simple |
comment:8 by , 3 years ago
Keywords: | simple added |
---|
Note:
See TracTickets
for help on using tickets.
r18614 attempted to solve this by checking whether the file exists and otherwise picking the default mappreview image.
However that approach only works for clients that have access to PNG files. The released versions on the other side only come with DDS files.
The
sprite = foo.png
part still works if there are only DDS files available, but theFileExists
call does not translate the PNG to DDS, thus always displays the default map preview image to clients with the released version.