Opened 7 years ago
Closed 5 years ago
#4334 closed defect (fixed)
[PATCH] Make Promotion use the common helper in Transform.js and update Transform.js
Reported by: | wraitii | Owned by: | wraitii |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 24 |
Component: | Simulation | Keywords: | patch |
Cc: | Patch: | Phab:D2026 |
Description (last modified by )
Promotion currently doesn't use the ChangeEntityTemplate function defined in Transform.js, which is bad, and it should.
In parallel, that function does not correctly copy enough things. The attached patch fixes that.
Attachments (3)
Change History (13)
by , 7 years ago
Attachment: | TransformFix.patch added |
---|
by , 7 years ago
Attachment: | TransformFix2.patch added |
---|
comment:2 by , 7 years ago
Fixed point 1 by making the unit cheer after the other orders are completed. This isn't perfect, but given the change it's impossible to do better.
Fixed point 2 by preventing promotion of garrisoned entities (see comment in Transform.JS).
comment:3 by , 7 years ago
I did a test of TransformFix2.patch I don't know if preventing promotion of garrisoned entities is wanted. Else test result:
- Garrison a macedonian spearman champ. Search the silver shield tech. Ungarrison the unit. It is not promoted and has an infinite xp bar (see screenshot for fun).
- (Visible)Garrison a range unit on a wall. When it get enough xp to promote, the xp bar is just reseted and start filling again. Ungarisonning it of the wall let him that new xp and don't promote it.
by , 7 years ago
Attachment: | promotion.jpg added |
---|
comment:4 by , 7 years ago
Keywords: | review removed |
---|
comment:7 by , 5 years ago
Component: | UI & Simulation → Simulation |
---|
Move tickets to Simulation
as UI & Simulation
got some sub components.
comment:9 by , 5 years ago
Milestone: | Backlog → Alpha 24 |
---|---|
Patch: | → Phab:D2026 |
I did a quick test (not a review).