Opened 7 years ago

Last modified 7 years ago

#4351 closed enhancement

[PATCH] Shadow map improvements — at Version 11

Reported by: Vladislav Belov Owned by: Vladislav Belov
Priority: Must Have Milestone: Alpha 23
Component: Core engine Keywords: patch
Cc: Patch:

Description (last modified by Sandarac)

Planned features:

  • Quality level selection (exists in current state): from Very Low (1/4x original size) to Very High (4x original size).
  • PSM optimization.

Current state: https://github.com/vladislavbelov/0ad/tree/shadows Comparasion: http://trac.wildfiregames.com/raw-attachment/ticket/4351/shadows_resized.png

Change History (13)

by Vladislav Belov, 7 years ago

Attachment: shadows_resized.png added

comment:1 by Vladislav Belov, 7 years ago

Keywords: patch rfc added
Owner: set to Vladislav Belov
Status: newassigned
Summary: Shadow map improvements[PATCH] Shadow map improvements

comment:2 by Vladislav Belov, 7 years ago

Description: modified (diff)

comment:3 by gameboy, 7 years ago

@vladislavbelov: Your patch is very good, you can formally submit them, I would like to know, you have to add the graphics anti aliasing features.

comment:4 by Lionkanzen, 7 years ago

Needs review may be.

in reply to:  3 comment:5 by Vladislav Belov, 7 years ago

Replying to gameboy:

@vladislavbelov: Your patch is very good, you can formally submit them, I would like to know, you have to add the graphics anti aliasing features.

I couldn't commit, so I'm waiting for dev comments/review. There is a work about FXAA (https://wildfiregames.com/forum/index.php?/topic/20175-programmer-graphics-gameplay-ai-mikita-hradovich-yet-another-game-developer-wants-to-participate/&page=2), but it looks blured. I will test FXAA & SSAO, but I'm not sure that will be ok.

comment:6 by Lionkanzen, 7 years ago

Add review tag to your work.

in reply to:  6 comment:7 by Vladislav Belov, 7 years ago

Replying to Lionkanzen:

Add review tag to your work.

Review queue for final patches, before it should be in the rfc queue.

comment:8 by Vladislav Belov, 7 years ago

Changed the option label to "Shadow Quality", as @mimo suggested.

comment:9 by gameboy, 7 years ago

Yes, about the graph anti-aliasing patch, the people who make the patch we have not contact with him, his patch still exist many problems not be processed Maybe you can refer to his graphic anti-aliasing capabilities, make your graphics anti-aliasing patches. http://trac.wildfiregames.com/ticket/3640

Last edited 7 years ago by gameboy (previous) (diff)

by Vladislav Belov, 7 years ago

Attachment: 4351_shadows.patch added

Current state

comment:10 by elexis, 7 years ago

Milestone: Alpha 22Work In Progress

Moving to the new WIP milestone.

comment:11 by Sandarac, 7 years ago

Description: modified (diff)

Refs #743.

Note: See TracTickets for help on using tickets.