Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#4350 closed defect (fixed)

[PATCH] Color of disabled gui elements

Reported by: Vladislav Belov Owned by: Vladislav Belov
Priority: Should Have Milestone: Alpha 22
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description (last modified by Vladislav Belov)

Some of elements has no disabled color (dropdown, label).

Comparison:

http://trac.wildfiregames.com/raw-attachment/ticket/4350/dropdown_resized.png

Attachments (7)

dropdown.png (159.9 KB) - added by Vladislav Belov 3 years ago.
dropdown_resized.png (284.8 KB) - added by Vladislav Belov 3 years ago.
4350_dropdown.patch (3.3 KB) - added by Vladislav Belov 3 years ago.
Adds a style for disabled dropdowns
4350_dropdown_label.patch (5.1 KB) - added by Vladislav Belov 3 years ago.
Adds a style for disabled dropdowns and labels
dropdown2.png (156.7 KB) - added by Vladislav Belov 3 years ago.
4350_dropdown_label.2.patch (6.1 KB) - added by Vladislav Belov 3 years ago.
Adds a style for disabled dropdowns and labels
4350_mainmenu.patch (1.0 KB) - added by Vladislav Belov 2 years ago.
Adds a style for disabled buttons

Download all attachments as: .zip

Change History (20)

Changed 3 years ago by Vladislav Belov

Attachment: dropdown.png added

Changed 3 years ago by Vladislav Belov

Attachment: dropdown_resized.png added

comment:1 Changed 3 years ago by Vladislav Belov

Description: modified (diff)

Changed 3 years ago by Vladislav Belov

Attachment: 4350_dropdown.patch added

Adds a style for disabled dropdowns

Changed 3 years ago by Vladislav Belov

Attachment: 4350_dropdown_label.patch added

Adds a style for disabled dropdowns and labels

comment:2 Changed 3 years ago by Vladislav Belov

Keywords: patch rfc added
Owner: set to Vladislav Belov
Status: newassigned
Summary: Color of disabled gui elements[PATCH] Color of disabled gui elements

comment:3 Changed 3 years ago by mimo

Nice! is it possible to also grey the selected value (here High in the Shadow quality dropdown) of a disabled dropdown? And maybe replace "Shadow quality" by "Shadow Quality" for consistency, although i should maybe have posted this to #4351 :-)

comment:4 in reply to:  3 Changed 3 years ago by Vladislav Belov

Replying to mimo:

Nice! is it possible to also grey the selected value (here High in the Shadow quality dropdown) of a disabled dropdown? And maybe replace "Shadow quality" by "Shadow Quality" for consistency, although i should maybe have posted this to #4351 :-)

I think, it's possible, I will try, also will replace to "Shadow Quality" in the #4351.

comment:5 in reply to:  3 Changed 3 years ago by Vladislav Belov

Replying to mimo:

Nice! is it possible to also grey the selected value (here High in the Shadow quality dropdown) of a disabled dropdown?

Fixed.

http://trac.wildfiregames.com/raw-attachment/ticket/4350/dropdown2.png

Last edited 3 years ago by Vladislav Belov (previous) (diff)

Changed 3 years ago by Vladislav Belov

Attachment: dropdown2.png added

Changed 3 years ago by Vladislav Belov

Attachment: 4350_dropdown_label.2.patch added

Adds a style for disabled dropdowns and labels

comment:6 Changed 2 years ago by elexis

Milestone: Alpha 22Work In Progress

Moving to the new WIP milestone.

comment:7 Changed 2 years ago by Imarok

refs #1532

comment:8 Changed 2 years ago by mimo

Resolution: fixed
Status: assignedclosed

In 19020:

Change color of disabled labels and dropdowns, patch by vladislavbelov, fixes #4350

comment:9 Changed 2 years ago by mimo

Keywords: rfc removed
Milestone: Work In ProgressAlpha 22

Thanks for the patch. When testing, I've noticed that button labels also are not greyed: just select SinglePlayer? in the menu, and the Campaigns button has still a white label. Maybe a next patch? :-)

comment:10 in reply to:  9 Changed 2 years ago by Vladislav Belov

Replying to mimo:

When testing, I've noticed that button labels also are not greyed: just select SinglePlayer? in the menu, and the Campaigns button has still a white label. Maybe a next patch? :-)

It's the small patch enough :)

Changed 2 years ago by Vladislav Belov

Attachment: 4350_mainmenu.patch added

Adds a style for disabled buttons

comment:11 Changed 2 years ago by Vladislav Belov

Keywords: rfc added

comment:12 Changed 2 years ago by mimo

In 19023:

modify color text of disabled buttons, refs #4350, patch by vladislavbelov

comment:13 Changed 2 years ago by mimo

Keywords: rfc removed

Thanks again for the quick fix.

Note: See TracTickets for help on using tickets.