[PATCH] AI Influence group type should become a descriptive string

[elexis]

#3934 exposed the AI configuration (aiAnalysisInfluenceGroup for resources to moddable JSON files. As discussed in ​https://wildfiregames.com/forum/index.php?/topic/21404-adding-new-resources/ these three values (0, 1, 2) should become (ignore, abundant, spare) to make it obvious that other values are not supported and making the code easier to read and grep.

[mimo]

Looks good to me, thanks for writing it. There is only one old typo in common-api/shared.js where "spare" should have been "sparse". So the corresponding string should be changed to "sparse".

[elexis]

(was wondering already)

[Stan]

Shouldn'it be scarce ? (Unless it means the resource is spread)

[mimo]

It's more connected to the fact that the resource is spread, and not necessarily scarce as each amount can be very big. It is only that when a resource is spread, its footprint in the resource map is bigger, to ensure that we won't miss a potentially good position if there are already a lot of obstructions around.

[elexis]

In 19012:

Use strings instead of integers for the values of aiAnalysisInfluenceGroup (used by petra to position dropsites). Reviewed by mimo, fixes #4377.

[elexis]

Thanks for the review!