Opened 7 years ago

Last modified 16 months ago

#4399 new defect

Splash screen version check should use md5 hash instead of file modification date

Reported by: elexis Owned by:
Priority: Nice to Have Milestone: Backlog
Component: UI – Miscellaneous Keywords:
Cc: Patch:

Description (last modified by elexis)

As pointed out in #4391, a file modification date isn't a good identifier to track content changes. The splash screen shouldn't be a bad example and check for actual content changes by using a quick md5 hash of the contents to compare.

https://github.com/elexis1/0ad/commits/splashscreen https://github.com/0ad/0ad/compare/master...elexis1:splashscreen.diff

Also includes the rephrasing mentioned in comment:6:ticket:4391, a GUI element size fix, duplication removal, moving of code from XML to JS and saves splashscreenversion when opening the page (not when closing it via OK).

Change History (8)

comment:1 by elexis, 7 years ago

Should the welcome screen be considered read when showing it or when clicking okay?

comment:2 by elexis, 6 years ago

Description: modified (diff)

Phab:D1575 for the md5sum version check of the lobby terms.

comment:3 by elexis, 6 years ago

In 21850:

Persist the lobby Terms Of Use and Terms Of Service checkbox if the logged in user and the accepted versions of the pages didn't change since last login, refs #5218.

This way the user is only forced to read the Terms again that changed or if the user logged in from a different machine.
Use md5sum since it is sufficiently resistant against collisions and doesn't freeze the window for 2 seconds like EncryptPassword / SHA256 does, refs #4399.
Use 0 instead of empty string in default.cfg, refs #3990.

Differential Revision: https://code.wildfiregames.com/D1575
Partial review by: Vladislav

comment:4 by Imarok, 5 years ago

Component: UI & SimulationMisc. UI

Move tickets to Misc. UI as "UI & Simulation" got some sub components.

comment:5 by Stan, 3 years ago

Keywords: patch rfc removed
Milestone: Work In ProgressAlpha 25

comment:6 by Stan, 3 years ago

Milestone: Alpha 25Alpha 26

Unlikely to happen for A25

comment:7 by Stan, 2 years ago

Milestone: Alpha 26Alpha 27

Unlikely to get done for A26

comment:8 by Freagarach, 16 months ago

Milestone: Alpha 27Backlog

Pushing back.

Note: See TracTickets for help on using tickets.