Opened 7 years ago
Last modified 16 months ago
#4399 new defect
Splash screen version check should use md5 hash instead of file modification date — at Initial Version
Reported by: | elexis | Owned by: | |
---|---|---|---|
Priority: | Nice to Have | Milestone: | Backlog |
Component: | UI – Miscellaneous | Keywords: | |
Cc: | Patch: |
Description
As pointed out in #4391, a file modification date isn't a good identifier to track content changes. The splash screen shouldn't be a bad example and check for actual content changes by using a quick md5 hash of the contents to compare.
https://github.com/elexis1/0ad/commits/splashscreen https://github.com/0ad/0ad/compare/master...elexis1:splashscreen.diff
Also includes the rephrasing mentioned in comment:6:ticket:4391, a GUI element size fix, duplication removal, moving of code from XML to JS and saves splashscreenversion
when opening the page (not when closing it via OK).
Note:
See TracTickets
for help on using tickets.