[PATCH] Empty server name causes a visual error and empty port

[Vladislav Belov]

If you set the server name to the empty string, then you will get a visual error:

Also there is no notification, that the server port is invalid, you can set even a string. But the port will be getValidPort(port_string), and if user had a mistake, then he won't know the current port.

[Vladislav Belov]

The port of a game will be normalized only if the user press enter on this input. Which isn't so obvious for the user.

[Vladislav Belov]

Adds a feedback if the server name or port is incorrect

[Vladislav Belov]

I don't think that we should call the getValidPort for each press event, it'd be good to tell to user what's the problem with the port.

[Vladislav Belov]

Fix the problem with empty items of clist/colist

[Vladislav Belov]

The last patch is fix to prevent the same error for other places, the first patch is still relevant, because I don't think that we need empty names and unknown ports.

[elexis]

It would be good to merge the 65535 with the other occurance and use something like g_MinPort and g_MaxPort or g_ValidPorts = { "min": 1, "max": 65535 } (to reduce magic numbers and allow changing the range without changing the code).

[Vladislav Belov]

Replying to elexis:

It would be good to merge the 65535 with the other occurance and use something like g_MinPort and g_MaxPort or g_ValidPorts = { "min": 1, "max": 65535 } (to reduce magic numbers and allow changing the range without changing the code).

Good point, should it be done in the patch above?

[Vladislav Belov]

I think we need to add this fix first, and then replace all occurrences. It's easier to review.

[elexis]

We will get a visual error if the item is empty, so we pass a non-visible char to save the height

Hack alert.

It seems better if we would use the max height of all text elements in all columns.

This way one would have a column with few pixel height only if its empty everywhere and have a bigger height if one of the columns has mulitple lines of text.

[elexis]

We agreed to use the space character due to the following requirements: 1) Using a hardcoded min height property would not suit for different font sizes 2) Because content of the cells is clipped, the empty space can never be rendered into a neighboring cell 3) We use the maximum height of all cells, so this case is only needed if all cells have no content. We (as in Vladislav) want to not ignore this case and cover all cases, to prevent the user from confusing this empty line with a separator.

We agreed to improve the comment to // Minimum height of a space character of the current font size to reflect these requirements.

Thanks for the patch! Those empty gamename games in the lobby were annoying and it indeed should be fixed in the C++ engine (too).

[elexis]

In 19306:

Use a minimum height of at least one space character of the current font size when drawing list rows.
Use the maximum height of all cells of the current row.
Lobby games with empty servernames are not rendered weirdly anymore.

Patch By: Vladislav
Fixes #4402

[elexis]

In 19307:

Prevent lobby players from hosting games with empty servernames.
Display a notification instead of using the default port if an invalid one was specified.

Patch By: Vladislav
Refs #4402

[elexis]

Strings suggested by scythetwirler, besides that "must"