Remove "More Options" window from the gamesetup

[elexis]

The "More Options" dialog hides most options. Especially clients have to keep switching between the main gamesetup page and the more-options dialog to keep track of the chosen settings.

2014-04-22-QuakeNet-#0ad-dev.log:14:08 < sanderd17> Yves_notebook, the "more options" could be part of the map settings tab, so it's just two screens again (two big instead of one big and one small)
2015-06-09-QuakeNet-#0ad-dev.log:15:06 < sanderd17> Also, a number of settings are hidden under the "more options" dialog, while players should be able to see them easier
2015-12-18-QuakeNet-#0ad-dev.log:13:02 < sanderd17> I still think a multi-screen setup is the only possible one, as now we're hiding a lot of options under the "more options" dialog, and players fail to check it (which can lead to strange results in multiplayer)
2016-06-04-QuakeNet-#0ad-dev.log:16:45 < sanderd17> Btw elexis, as you are rewriting the gamesetup, will you get rid of that annoying "more settings" button?
2016-06-04-QuakeNet-#0ad-dev.log:16:54 < sanderd17> But such a small button is the typical example of lack of GUI design ... the dev has no space for the settings, so he adds a "more options" button and puts everything new under there
2016-06-04-QuakeNet-#0ad-dev.log:17:29 < sanderd17> elexis, so it's not a "more options" button if it's easier to say what options it doesn't contain. It's an "almost all options" button.
2016-06-04-QuakeNet-#0ad-dev.log:17:31 < sanderd17> I'd put map selection + the current more options on one screen, and player assignments on the next screen

A 2-way dialog is an absolute no go for multiplayer to me. Players join the game not knowing what map and settings they want to play and leave the game if the host doesn't comply with their demands. It takes long discussions and considerations to please everyone, which would be made impossible when fixing on settings before. If we switch back and forth between 2 pages, we worsened the original problem.

It seems better to, after implementing scrolling for arbitrary objects in #3038, have two tabs below the mappreview, one containing all options and one containing a human-readable description of the settings (#4141).

2016-08-11-QuakeNet-#0ad-dev.log:15:33 < elexis> sanderd17: is that ok? http://trac.wildfiregames.com/attachment/ticket/4141/screenshots.png
2016-08-11-QuakeNet-#0ad-dev.log:15:35 < sanderd17> Ah, that's nice
2016-08-11-QuakeNet-#0ad-dev.log:15:35 < sanderd17> So it's finally less hidden

[elexis]

The complete list of gamesettings is displayed since the introduction of the objectives dialog gamedescription.js in r18692. So the reported problem of gamesettings being hidden under a clumsy UI isn't given anymore (iirc sanderd17 also mentioned that on irc once but I couldn't find the citation (except after reading the ticket description...)).

In a23 there was also bb's gamesetup UI patch which replaced the "More Options" dialog with 3 tab buttons, making this ticket further obsolete.

Scrolling could or should replace the 3 tab buttons eventually, don't see the need for the ticket for that.