#4438 closed defect (fixed)
[PATCH] Hitting cancel while connecting to the lobby doesn't cancel request
| Reported by: | sbirmi | Owned by: | sbirmi |
|---|---|---|---|
| Priority: | Should Have | Milestone: | Alpha 22 |
| Component: | Multiplayer lobby | Keywords: | patch |
| Cc: | Patch: |
Description (last modified by )
This was discovered while investigating #3941 (see comment 6http://trac.wildfiregames.com/ticket/3941#comment:6). Repeating here for completeness:
In lobbyStartConnect(), as as soon as Engine.ConnectXmppClient?() returns, we render "Connecting..." for example. Now, control is resumed to the gui. I tried hitting "Cancel". The connect screen returns to page "pageWelcome". However,
- feedback.caption is not reset (so you see "Connecting..." appearing in the backend).
- also, looks like we probably (don't reset g_LobbyIsConnecting or something similar). We actually end up connecting to the lobby (the UI switches to the next page) still.
Note that this should also happen when we try to register (but I didn't test creating bogus accounts).
Attachments (5)
Change History (8)
by , 7 years ago
| Attachment: | 4438-lobby-cancel-fix-v1.patch added |
|---|
by , 7 years ago
| Attachment: | 4438-lobby-cancel-fix-v1.2.patch added |
|---|
comment:1 by , 7 years ago
| Keywords: | rfc patch added |
|---|---|
| Summary: | Hitting cancel while connecting to the lobby doesn't cancel request → [PATCH] Hitting cancel while connecting to the lobby doesn't cancel request |
by , 7 years ago
| Attachment: | 4438-lobby-cancel-fix-v2.patch added |
|---|
v1 description + reusing lobbyStop + adding name to programming.json
by , 7 years ago
| Attachment: | screenshot_01_welcome_screen_with_old_caption.png added |
|---|
(without the fix) if cancel is hit while registration is going on, we are switched to the welcome page without clearing caption and stopping the xmpp client
by , 7 years ago
| Attachment: | screenshot_02_later_redirected_to_registration_successful_page.png added |
|---|
(without the fix) .. and despite being on the welcome page, are later redirected to the registration-successful page
comment:3 by , 7 years ago
| Description: | modified (diff) |
|---|---|
| Keywords: | rfc removed |
| Milestone: | Work In Progress → Alpha 22 |
Thanks for the patch!
instead of just switch page, cancel pending xmpp request when hitting cancel