Opened 3 years ago

Closed 2 years ago

#4458 closed defect (fixed)

[PATCH] xmlvalidator perl scripts tool

Reported by: fatherbushido Owned by:
Priority: Should Have Milestone: Alpha 22
Component: Art & Animation Keywords: patch
Cc: Patch:

Description (last modified by fatherbushido)

When running it: I got

Validating actors...
/public/art/actors/units/macedonians/champion_cavalry_e.xml:0: Relax-NG validity error : Element variant has extra content: colour
/public/art/actors/units/macedonians/champion_cavalry_e.xml:0: Relax-NG validity error : Element group has extra content: variant
Relax-NG validity error : Extra element group in interleave
/public/art/actors/units/macedonians/champion_cavalry_e.xml:0: Relax-NG validity error : Element actor failed to validate content

1 actor validation errors

Validating variants...
[...]
34 variant validation errors

So I wonder if it is up to date or if there is those errors in art templates.

Attachments (1)

4458.diff (1.4 KB) - added by stanislas69 3 years ago.
Remove the occurences of "<colour>" in the file and replace them by "<color>"

Download all attachments as: .zip

Change History (8)

comment:1 Changed 3 years ago by stanislas69

Keywords: rfc patch added
Milestone: BacklogWork In Progress
Summary: xmlvalidator perl scripts tool[PATCH] xmlvalidator perl scripts tool

It is indeed an error, since colour tags were replaced by color in r16438.

Changed 3 years ago by stanislas69

Attachment: 4458.diff added

Remove the occurences of "<colour>" in the file and replace them by "<color>"

comment:2 Changed 3 years ago by fatherbushido

Thanks stan

the following errors are

Validating variants... Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_archer_chariot_ready.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_archer_ready.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_archer_relax.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_archer_relax_fem.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_driver_chariot.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_driver_chariot_celt.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_healer.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_healer_female.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_hoplite.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_jav_chariot_ready.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_rhomphaia_shield.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_rhomphaia_shield_fast.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_skirmisher.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_skirmisher_heavy.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_slave_male.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_slinger_ready.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_spearman_ready.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_spearman_ready_fast.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_spearman_ready_smallshield.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_spearman_relax.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_swordsman_2hand_ready.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_swordsman_2hand_relax.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_swordsman_shield_fast.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_swordsman_shield_fast_relax.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_swordsman_shield_ready.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_swordsman_shield_relax.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_swordsman_shieldarm.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_swordsman_shieldarm_fast.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_swordsman_shieldsmall_fast.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/base_trader.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/death_infantry.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/female_death.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/gather_praise.xml:0: Relax-NG validity error : Element variant failed to validate content Relax-NG validity error : Extra element animations in interleave /public/art/variants/biped/pikeman_base.xml:0: Relax-NG validity error : Element variant failed to validate content

34 variant validation errors

comment:3 Changed 3 years ago by wraitii

That's probably because the variants are not legal actor files on their own I think, see https://code.wildfiregames.com/D62

comment:4 Changed 3 years ago by fatherbushido

In 19140:

Remove remaining colour occurence in art files as done in r16438. Patch by stanislas69. Refs #4458.

comment:5 Changed 3 years ago by fatherbushido

@stanislas69: Thanks for the patch.

(yes I checked the whole art folder).

comment:6 Changed 3 years ago by fatherbushido

Keywords: rfc removed

comment:7 Changed 2 years ago by fatherbushido

Description: modified (diff)
Milestone: Work In ProgressAlpha 22
Resolution: fixed
Status: newclosed

Fixed by r19660 and r19661

Note: See TracTickets for help on using tickets.