Opened 7 years ago

Closed 7 years ago

#4495 closed defect (fixed)

RangeManager returns Gaia entities in GetNonGaiaEntities

Reported by: elexis Owned by:
Priority: Must Have Milestone: Alpha 22
Component: Core engine Keywords:
Cc: Patch:

Description

Reproduce:

  1. Spawn entities from a trigger script, f.e. using SpawnUnitsFromTriggerPoints with owner 0
  2. Call GetNonGaiaEntities in the same function after spawning
  3. Check the owner of each entity returned and notice the new entities spawned are included

Observed in ​https://code.wildfiregames.com/file/data/yiufk4q5ii4chh343tyf/PHID-FILE-w6z7afkqgvmarxlu3uy6/D156.id584.diff

Change History (4)

comment:1 by mimo, 7 years ago

the code of GetNonGaiaEntities() looks wrong return GetEntitiesByMask(((1 << MAX_LOS_PLAYER_ID) - 1) << 1); should be return GetEntitiesByMask(((1 << MAX_LOS_PLAYER_ID) - 1) << 2); as bit 0 is for owner=-1 and bit 1 is for owner=0

comment:2 by mimo, 7 years ago

In 19245:

RangeManager returns Gaia entities in GetNonGaiaEntities
refs #4495
Reviewed By: leper, elexis
Differential Revision: ​https://code.wildfiregames.com/D164

comment:3 by mimo, 7 years ago

Milestone: Backlog → Alpha 22

comment:4 by mimo, 7 years ago

Resolution: → fixed
Status: new → closed
Note: See TracTickets for help on using tickets.