Changes between Initial Version and Version 1 of Ticket #4501, comment 3


Ignore:
Timestamp:
May 5, 2017, 2:37:45 AM (7 years ago)
Author:
elexis

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4501, comment 3

    initial v1  
    1 (Looks lke the commit to add lobby informaiton that diplayed lobby stanza data that was constructed solely from g_GameAttributes in r18534 was the latest commit that should have considered that given enough preknowledge about gamesetup pitfalls. The one that exposed `g_GameAttributes` to `session.js` would have been better of having it fixed too.)
     1In earlier versions of gamesetup, the property wasn't set either, but replaced with the default whenever using it.
     2https://code.wildfiregames.com/source/0ad/browse/ps/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js;17218$1502
     3
     4Looks lke the commit to add lobby informaiton that diplayed lobby stanza data that was constructed solely from g_GameAttributes in r18534 was the latest commit that should have considered that given enough preknowledge about gamesetup pitfalls. The one that exposed `g_GameAttributes` to `session.js` would have been better of having it fixed too.