Incomplete Healrange visualization circle

[elexis]

When training the mauryan healer hero, we can observe that it's range visualization is an incomplete circle.

It occurs with the regular healer too if the range is upgraded at the temple.

It sounds like a rounding issue in UpdateTexturedLineOverlay of CCmpSelectable.cpp.

See also ​Phab:D571

[fatherbushido]

If one just draw half of the points, it seems the line won't be closed (even if we can see something when moving the healer).

[elexis]

Screenshot from Alpha 21

[elexis]

The issue can be reproduced with building footprints as well, even before the aura range commit in alpha 21:

[fatherbushido]

(The subdivision code needs some cleaning/simplification). Else the issue is just in TextureLineRData. The V coordinate is switched from 0 to 1 at each turn. But for a closed line, if we have an odd number of 'points' the last point and the first will get the same V and so even if the quad is completed, we will not see it. (One could notice there is something traced). That bug won't be noticed when there is an even number of point (which is the case for an healer without tech).

[fatherbushido]

refs r19519 r19679 r19708

[fatherbushido]

In 19833:

Properly apply texture to the last quad of an overlay textured line. Reviewed by vladislavbelov.
Fix #4617.
Differential Revision: ​https://code.wildfiregames.com/D663

[elexis]

Thanks! It would have been really annoying for players and devs now that the bug became more apparent.