#4658 closed defect (fixed)
Ranged aura still applied even when garrisoned
Reported by: | elexis | Owned by: | bb |
---|---|---|---|
Priority: | Must Have | Milestone: | Alpha 23 |
Component: | UI & Simulation | Keywords: | |
Cc: | Patch: | Phab:704, Phab:D1219 |
Description
Retardado has reported that sometimes Hero auras are even applied to units if the hero is garrisoned and if that aura is a ranged aura.
Replay the attached r19835 replay to reproduce.
Attachments (2)
Change History (13)
by , 7 years ago
Attachment: | commands.txt added |
---|
comment:1 by , 7 years ago
Confirmed. Already in a21. It's wrong as after the aura source is garrisoned, the affected unit can go at the other side of the map with still the bonus applied (edit: which leads to an exploit).
comment:2 by , 7 years ago
We could call a this.Clean()
on garrison.
But it's weird that it's not already handle by OnRangeUpdate
.
edit:
For the active query, when the source of the query is garrisoned, the RangeUpdate
message is not sent (we would expect that all current queried entities are in msg.removed
). So, imo, it seems it's in perhaps manager that it should be fixed. But I wouldn't do too much expectation on what RangeManager
is expected or not expected to do.
comment:3 by , 7 years ago
Attached patch actually updates the queries when the source of an active query is (put) out of world. (rfc)
(for the said problem, build a fortress, an hero (bouddica for example), a champion, garrison the hero, and check for example the capture stat).
comment:6 by , 7 years ago
Milestone: | Backlog → Alpha 22 |
---|
Not a release blocker, but the genie is out of the bottle.
by , 7 years ago
Attachment: | t4658.diff added |
---|
comment:7 by , 7 years ago
Patch: | → Phab:D704 |
---|
comment:8 by , 7 years ago
Milestone: | Alpha 22 → Work In Progress |
---|
From the meeting today:
(19:19:45) elexis: #4658 looks like it needs an update, so might have to be pushed while fatherbushido is N/A and hope that players dont find out about the garrison ranged aura bug (19:20:57) Itms: Push #4658
comment:9 by , 6 years ago
Patch: | Phab:D704 → Phab:704, Phab:D1219 |
---|
Notice the bug occurs upon the first garrison, but later it doesn't.