Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#477 closed defect (wontfix)

include svn revision number

Reported by: fabio Owned by:
Priority: If Time Permits Milestone: Alpha 3
Component: Non-game systems Keywords:
Cc: Patch:

Description

WRT r7400 it would be nice to also include svn version from which the code get compiled, see http://subversion.apache.org/faq.html#version-value-in-source

Change History (6)

comment:1 by Philip Taylor, 14 years ago

We tried to set that up a while ago (see svn_revision) - the problem was that svnversion is quite slow (it has to check the entire working copy), and adding a couple of seconds to every build is bad for iteration times during development. I don't know how we could avoid that cost while still being sure the recorded number is reliable.

(Also we'd need to be more careful to not update the saved revision number unless it changes, to avoid unnecessary recompilation and re-linking each time the file is regenerated, and it might take a little effort to work out how to do that on Windows.)

Currently svn_revision.txt is only updated by the Windows autobuilder, and the snapshots in #463 will be given the right number. Normal SVN checkouts just get "custom build" and no number.

It'd be good to find a solution which

  • doesn't slow down incremental rebuilds by more than a tiny bit (maybe ~100ms)
  • reliably indicates the revision of the code that was compiled (so we don't waste time debugging problems based on incorrect information)
  • works on all platforms

comment:2 by (none), 14 years ago

Milestone: Unclassified

Milestone Unclassified deleted

comment:3 by Andrew, 14 years ago

Milestone: Backlog

comment:4 by fabio, 14 years ago

I think that this could be closed since regular users should be using the provided tarballs which other than the revision number also include the precompressed texture. Also ubuntu packages in the 0ad.dev PPA are using this approach. Users compiling from svn should know how to get the svn revision.

comment:5 by fabio, 14 years ago

Resolution: wontfix
Status: newclosed

Closing: regular users using prebuilt packages (windows, PPA) already have revision number; who build from svn should know what is doing and how to know revision number.

comment:6 by Kieran P, 14 years ago

Milestone: BacklogAlpha 3
Note: See TracTickets for help on using tickets.