Opened 7 years ago
Last modified 5 years ago
#4770 closed defect
Organize treasure templates — at Version 7
| Reported by: | fatherbushido | Owned by: | |
|---|---|---|---|
| Priority: | Should Have | Milestone: | Alpha 23 |
| Component: | UI & Simulation | Keywords: | |
| Cc: | Patch: |
Description (last modified by )
Treasure templates inherit from template_gaia_treasure. But it seems that some are in other/ folder and some are in /gaia folder. Task:
- check if that is intended (commit history will help)
- move the according template in the adhoc folder
- change the refs in the maps files
template_gaia_treasure.xml gaia/special_ruins.xml gaia/special_ruins_column_doric.xml gaia/special_ruins_standing_stone.xml gaia/special_ruins_stone_statues_egyptian.xml gaia/special_ruins_stone_statues_roman.xml gaia/special_treasure_food_barrel.xml gaia/special_treasure_food_barrels_buried.xml gaia/special_treasure_food_bin.xml gaia/special_treasure_food_crate.xml gaia/special_treasure_food_jars.xml gaia/special_treasure_food_persian_big.xml gaia/special_treasure_food_persian_small.xml gaia/special_treasure_golden_fleece.xml gaia/special_treasure_metal.xml gaia/special_treasure_metal_persian_bigl.xml gaia/special_treasure_metal_persian_small.xml gaia/special_treasure_pegasus.xml gaia/special_treasure_standing_stone.xml gaia/special_treasure_stone.xml gaia/special_treasure_wood.xml other/special_treasure_shipwreck.xml other/special_treasure_shipwreck_debris.xml other/special_treasure_shipwreck_ram_bow.xml other/special_treasure_shipwreck_sail_boat.xml other/special_treasure_shipwreck_sail_boat_cut.xml
Change History (7)
comment:1 by , 7 years ago
| Summary: | Organize treasure template → Organize treasure templates |
|---|
comment:2 by , 7 years ago
comment:3 by , 7 years ago
In the same spirit, gaia ruins templates are in other/ and in gaia/
(That other/ folder...)
comment:4 by , 7 years ago
ruins and treasure in gaia/:
Ruins work the same way as resources. On the other hand they are man-made, so not what we see as "gaia".
So perhaps treasure and ruins should just be moved to other/.
Then gaia looks clean enough IMO and doesn't for instance need new subdirectories.
other/ and special/:
other/territory_pull.xml is weird. It's the only entity that isn't visible ingame, so maybe that should be moved to some "special" directory that isn't special/ according to the unplaceable definition. (Rename special/ to unplaceable/?)
The palisade templates should be moved to templates/ and/or template/structures/ as proposed by some other ticket. Then other/ will be clean enough too I guess. (subdirectories like units and structures possibly, dunno)
comment:6 by , 7 years ago
Well looking a bit at history, I won't sum up that here.
r7259 is the sim2 initial commit with only 1 thing in other/
r7889 r7980 r8110 for example started to populate other/ with mostly gaia or decorative things
r8150 similar things are commited in gaia/
r10650 introduced proper treasure and ruins generic templates
r11066 some things in other/ change their parents
r8571 some things are added in other/ and some are changed in gaia/
I stopped that here. I am for moving ruins and treasures in other/ which inherits from that template_gaia_foo things to gaia/ (also I wonder if _special_ in the name of those templates is really relevant)
comment:7 by , 7 years ago
| Description: | modified (diff) |
|---|
(edit description: alphabetic sorting + ruins)
Should do a text search for
other/, I suspect some things in the structree, rmgen and selection panels (and perhaps AI code) might need to be renamed (nothing serious though).