Opened 6 years ago

Last modified 5 years ago

#4948 new defect

Wrong order of joining shown in gamesetup

Reported by: Dunedan Owned by:
Priority: If Time Permits Milestone: Backlog
Component: Network Keywords:
Cc: Patch:

Description

When joining a game in the lobby it shows joining messages for all participants. These messages aren't in the order of joining.

E.g. in the attached screenshot I joined as fourth player, but the messages suggest I joined as second player.

Attachments (1)

wrong_join_order.png (352.1 KB ) - added by Dunedan 6 years ago.

Download all attachments as: .zip

Change History (5)

by Dunedan, 6 years ago

Attachment: wrong_join_order.png added

comment:1 by elexis, 6 years ago

Component: UI & SimulationNetwork

I doubt we need the NetServer to recollect the join order, right?

So we could just show a different string for joins received upon join.

comment:2 by elexis, 6 years ago

Milestone: Backlog

Is actually the entire join order of relevance or is it only that the host should come first? The latter can be addressed easily, the former seems like unneeded complexity.

comment:3 by Imarok, 6 years ago

The assignments are stored in a std::map, so it is not chronologically ordered. I also don't see much sense in doing so.

Therefore I suggest to show already joined users in this format to any later joining player:

$host has joined
$client1, $client2, $client3 has joined

Version 0, edited 6 years ago by Imarok (next)

comment:4 by historic_bruno, 5 years ago

Milestone: Backlog
Note: See TracTickets for help on using tickets.