Opened 2 years ago

Closed 2 years ago

Last modified 21 months ago

#4970 closed enhancement (fixed)

History structure tree switch

Reported by: fpre_O_O_O_O_O_O Owned by: fpre_O_O_O_O_O_O
Priority: Nice to Have Milestone: Alpha 23
Component: UI & Simulation Keywords: History structure tree
Cc: Patch: Phab:D846

Description

As discussed with community players and mod/player mapkoc, there should be a switch button between history page and structure tree to easily switch between them, especially in certain situations as when in game or in game setup, where so such options to open both.



Code is finished and ready to commit.

Change History (8)

comment:1 Changed 2 years ago by fpre_O_O_O_O_O_O

Owner: set to fpre_O_O_O_O_O_O
Status: newassigned

comment:2 Changed 2 years ago by FeXoR

Where is the code? How is this a defect?

comment:3 Changed 2 years ago by elexis

See the link in the patch. Not a defect but many players missed a way to switch from structree to the history page back and forth (especially ingame to see the civ bonuses).

comment:4 Changed 2 years ago by elexis

s0600204's answer was given in Phab:D297:

I'm not totally against having a button, it was the merging of the two pages (which was the original intent of that revision) I was against.

comment:5 Changed 2 years ago by elexis

Patch: https://code.wildfiregames.com/D846Phab:D846
Priority: Should HaveNice to Have
Type: defectenhancement

comment:6 Changed 2 years ago by s0600204

Resolution: fixed
Status: assignedclosed

(As the post-commit hook seems to have failed:)

Committed in r21339

comment:7 Changed 2 years ago by s0600204

In 21681:

Change key shortcut for Structure Tree.

So it doesn't collide with silhouette toggling.

Ok'd by: fpre
Refs: #4970, D846, rP21339, r21339

comment:8 Changed 21 months ago by elexis

In 21882:

Gamesetup cleanup.

Move civInfo press event handling from XML to the JS GUI object data from rP19504 / D322.
Equally move civInfo tooltip from init (which should remain agnostic of content) following rP21339 / D846, refs #4970.

Note: See TracTickets for help on using tickets.