Opened 6 years ago

Closed 4 years ago

#5008 closed defect (fixed)

Update Checkref.pl

Reported by: Stan Owned by: Stan
Priority: Nice to Have Milestone: Alpha 24
Component: Build & Packages Keywords:
Cc: Patch:

Description

The scripts that checks all the reference of all files to find unused stuff is currently broken somewhat.

It'd be nice to update it. It should take into account variants, also, it should not break for Json.

Attachments (1)

variant_support.diff (1.3 KB ) - added by Stan 6 years ago.
This patch makes variant part of the script.

Download all attachments as: .zip

Change History (5)

comment:1 by elexis, 6 years ago

somewhat should be specified. I guess you already noticed the ticket on the a23 milestone.

comment:2 by Stan, 6 years ago

Ah so yeah, that's part of it.

Variants are not taken into account leading to false positives in the script. Biomes are not taken into account #4777

Random maps trigger errors

Loading random maps...
Use of uninitialized value in concatenation (.) or string at checkrefs.pl line 444.
Use of uninitialized value in concatenation (.) or string at checkrefs.pl line 444.
Use of uninitialized value in concatenation (.) or string at checkrefs.pl line 444.
Use of uninitialized value in concatenation (.) or string at checkrefs.pl line 444.
Use of uninitialized value in concatenation (.) or string at checkrefs.pl line 444.
Use of uninitialized value in concatenation (.) or string at checkrefs.pl line 444.
Use of uninitialized value in concatenation (.) or string at checkrefs.pl line 444.
Use of uninitialized value in concatenation (.) or string at checkrefs.pl line 444.
Use of uninitialized value in concatenation (.) or string at checkrefs.pl line 444.
Use of uninitialized value in concatenation (.) or string at checkrefs.pl line 444.
Use of uninitialized value in concatenation (.) or string at checkrefs.pl line 444.
Use of uninitialized value in concatenation (.) or string at checkrefs.pl line 444.

and GUI too

Loading GUI XML...
Can't stat ../../../binaries/data/mods/public/gui/modmod: No such file or directory
 at checkrefs.pl line 50.

by Stan, 6 years ago

Attachment: variant_support.diff added

This patch makes variant part of the script.

comment:3 by Stan, 4 years ago

Cc: Itms removed
Milestone: BacklogAlpha 24
Owner: set to Stan

comment:4 by Stan, 4 years ago

Resolution: fixed
Status: newclosed

Fixed in r22096

Improve and fix checkrefs.pl, add a readme for usage, add mod support, add command line arguments. Reviewed by: @Itms Comments by: @elexis

Differential Revision: ​https://code.wildfiregames.com/D1381

Note: See TracTickets for help on using tickets.