Opened 6 years ago

Closed 6 years ago

#5044 closed defect (fixed)

Command-line replay complains about mods

Reported by: elexis Owned by: Imarok
Priority: Should Have Milestone: Alpha 23
Component: Core engine Keywords:
Cc: Patch: ​Phab:D1316

Description

When doing a non-visual replay we get this error: 

WARNING: JavaScript warning: Script value conversion check failed: v.isString() || v.isNumber() (got type object)
WARNING: The mod 'public,0.0.23' is required by the replay file, but wasn't passed as an argument!
WARNING: The mod 'mod' wasn't used when creating this replay file, but was passed as an argument!
WARNING: The mod 'public' wasn't used when creating this replay file, but was passed as an argument!

Change History (4)

comment:1 by elexis, 6 years ago

Milestone: Backlog → Alpha 23

comment:3 by elexis, 6 years ago

Patch: → Phab:D1316

comment:4 by Imarok, 6 years ago

Owner: set to Imarok
Resolution: → fixed
Status: new → closed

In 21603:

Fix mod check of non-visual replays and allow conversion of a vector of vectors of strings via ScriptConversions

Reviewed by: elexis
Fixes #5044
Differential Revision: ​https://code.wildfiregames.com/D1316

Note: See TracTickets for help on using tickets.