Network: Should call enet_initialize

[Philip Taylor]

Documentation for enet_initialize says:

Must be called prior to using any functions in ENet.

We don't call it at all. We probably should. (It does nothing on Unix, but calls WSAStartup and timeBeginPeriod on Windows; need to make sure that doesn't interfere with our own wsock or timer code.)

[Jan Wassenberg]

Some background info:

but calls WSAStartup and timeBeginPeriod on Windows; need to make sure that doesn't interfere with our own wsock or timer code.)

our wsock.cpp contains some magic to automatically call WSAStartup when the wsock DLL is loaded (via delay-load notification). MSDN says WSAStartup can be called multiple times.

timeBeginPeriod can only decrease the timer interrupt period - requests for a lower frequency are ignored. If our timer backend decides to use timeGetTime, it'll also set timeBeginPeriod(1). There is no harm or conflict (other than increased interrupt overhead).

So: it's fine to call enet_initialize, but currently unnecessary (which is why it works without).

[Philip Taylor]

ENet calls WSAStartup with version (1, 1), wsock.cpp calls it with version 0x0002. What happens when it's called multiple times with different versions? Will either piece of code break if it gets an unexpected version of Winsock?

[Jan Wassenberg]

0x0002 is 2.0, which is the newer ws2_32.dll. 2.0 is a superset of 1.1, and introduces functions we use (getaddrinfo). However, I'd be surprised to see ws2_32 restrict the functions that can be called based on the requested version:

1) wsock32.dll appears to be implemented in terms of ws2_32 (note 25 KB file size and dependency on ws2_32)

2) see last post in ​http://www.mofeel.net/40-microsoft-public-win32-programmer-networks/7031-2.aspx

If there does turn out to be trouble, then the proposed solution is to change enet's request to 2.0 - 1.0 and 1.1 are ancient and we don't support Win9x anyway.

[philip]

(In [7681]) Call enet_initialize (see previous commit message). Fixes #509.

[(none)]

Milestone Unclassified deleted