Opened 6 years ago

Closed 4 years ago

Last modified 4 years ago

#5109 closed defect (fixed)

Tech modified cost wrong in observermode / Team bonus not visible if Observer item is selected

Reported by: elexis Owned by: Silier
Priority: Must Have Milestone: Alpha 24
Component: Simulation Keywords:
Cc: Patch: Phab:D2054


The iberian team bonus is skirmisher cost 40 instead of 50 wood. But in Observermode it depends on the selected perspective whether it is displayed correctly in the tooltip.


  1. Gamesetup:
    1.a. 3 players
    1.b. civs: Iber, Gaul, Anything
    1.c. teams: 112
    1.d. Set all slots to unassigned, so you start as an observer
  1. Session:
    2.a. Start the match
    2.b. Select the Gaul CC and notice it says 50 wood when it should be 40
    2.c. Select the Gaul player perspective and notice it says 40 wood

Reproducible with a22 and a23.

Change History (9)

comment:1 by fatherbushido, 6 years ago

more global than team bonus, any (aura?) modified cost

edit: tech modified one too

Last edited 6 years ago by fatherbushido (previous) (diff)

comment:2 by elexis, 6 years ago

(It's likely some GUIInterface calls using g_ViewedPlayer rather than the entity owner, but I stopped looking.)

comment:3 by temple, 6 years ago

Looks like g_TemplateData stores the template information, but it doesn't split them up by players. That makes sense for active players since they can only build and view their own units, but for observers all "units/rome_infantry_javelinist_b" will be treated the same, regardless of the owner.

Shouldn't be too hard to fix, just a continuation of r17617. (Not that I'm volunteering to fix it.)

comment:4 by elexis, 6 years ago

Summary: Team bonus not visible if Observer item is selectedTech modified cost wrong in observermode / Team bonus not visible if Observer item is selected

comment:5 by Imarok, 5 years ago

Component: UI & SimulationSimulation

Move tickets to Simulation as UI & Simulation got some sub components.

comment:6 by elexis, 5 years ago

Milestone: BacklogWork In Progress
Patch: Phab:D2054

comment:7 by Silier, 5 years ago

Owner: set to Silier

comment:8 by Silier, 4 years ago

Resolution: fixed
Status: newclosed

In 23237:

Apply modifications to template values based on entity owner instead watching player

When observer selects some building he can see possible units to be trained. Data about that templates are returned with id of observer what means no technologies or bonuses for selected player have been applied to the template. So observer does not see correct information in tooltip.

Differential Revision:
Fixes: #5109
Tested by: Nescio

comment:9 by Silier, 4 years ago

Milestone: Work In ProgressAlpha 24
Note: See TracTickets for help on using tickets.