Support download of lobby terms and conditions from the room

[elexis]

Ideally we wouldn't have to commit the lobby terms and conditions as a textfile but it would be downloaded from the server prior to room entrance.

This way policies could be updated during releases too.

XMPP mentions only one sentence about privacy policies: ​https://xmpp.org/extensions/xep-0045.html#disco-roominfo

an entity may also query a specific chat room for more detailed information about the room An entity SHOULD do so before entering a room in order to determine the privacy and security profile of the room configuration.

It seems the roominfo_description field would have to carry the terms that are accepted by entering and using the room.

The gloox client may support it already or would have to be patched (which shouldn't be too hard): ​https://camaya.net/api/gloox/classgloox_1_1MUCRoom.html

Notice translations would have to be downloaded as well.

refs ​Phab:D1590 and ​https://wildfiregames.com/forum/index.php?/topic/24325-gdpr/&page=6

[Stan]

Could someone who modifies the lobby address in their mods ( If that's possible) use that feature to download malicious code on the users computer ?

Like the user reporter we wouldn't support nor endorse those mods.

[elexis]

The download mechanism would be a gloox room-description getter, that then either contains all data (sounds messy with translations) or an URL that would provide strings only. That data wouldn't be written to the disk, could be XML and validated and then only displayed. Then the most malicious mod could only show a different policy or skip the policy. Not really possible to prevent the latter and legally probably not mandatory. Last time I checked a certain mod already provides a lobby login skip, that would be against the terms and will have to be solved on the moderation layer.

[Stan]

Sounds good. For translations maybe we could download the string using the current locale ? Updating pot files seem messy.