Allow right-clicking on disabled buttons

[cpc]

Thanks for this great game!

Right clicking on UI buttons shows extra information, but only when the button is enabled. When the button is disabled (for lack of resources, for example), right-clicking on it does nothing. It would be great if the right-click information was available even when the left-click action isn't available.

There are multiple possible implementations:

• Always allow right clicks (see attached patch)
• Add an enabledRight property in addition to enabled
• Stop using the enabled property and add an early return to the onPress handler instead where relevant.

[Stan]

Hello. Thanks for the patch unfortunately our review process has changed and you must now submit it to code.wildfiregames.com.

Sorry for the inconvenience and thanks for your interest.

[Imarok]

I'd also prefer your second option.

[elexis]

That's a known issue for sure. Wasn't this reported in a different ticket already? Only found these ​Phab:rP21310 / ​Phab:D297 / #3212, ​Phab:D1383, but that doesn't mention this issue. Perhaps there was an IRC discussion (​http://irclogs.wildfiregames.com/) about this, enabled_right was discussed.

[elexis]

Ah, duplicate of #5269, I will reference the patch there.

[cpc]

Ah, thanks a lot for spotting that duplicate! I searched for a while, but I wasn't as successful as you were.

[cpc]

stanislas69: Thanks, I will submit the patch to the appropriate location; I was hoping to discuss implementation strategies before submitting the code for formal review, to avoid wasting reviewer time.