Grab mouse in fullscreen

[Jay Weisskopf]

When the game is running in fullscreen, the mouse should be grabbed so it cannot move outside the game. I have multiple monitors, so when I try to pan the camera by putting the cursor along the edges, it moves right into the next monitor, which is a major annoyance.

Attached is a patch to fix the issue.

The ideal functionality for mouse grabbing would probably be to have it always grabbed in fullscreen, and optionally grabbed during gameplay in windowed mode (but not on menus, dev console, text entry, etc). I can also implement this if desired (it'd be a good way for me to start getting my feet wet).

[Jay Weisskopf]

Patch for grabbing mouse when game is fullscreen.

[Philip Taylor]

See #508 for a similar issue. That was from before r7686 implemented SDL_WM_GrabInput on Windows - seems good to use that function now we have it.

What platforms have you tested this on? On Windows, does it avoid the bugs mentioned in a comment on that ticket? (I'd prefer to fix them or at least be fully aware of them before committing the change.)

[Jay Weisskopf]

Yes, using SDL_WM_GrabInput is better than modifying the functionality of SDL_Set_VideoMode. The SDL emulation should adhere as closely to native SDL as possible. (I'm quite puzzled as to why you're even emulating it, but that's a discussion for IRC or the forum.)

I recommend you commit my patch, just so the major annoyance is gone, and close this issue. I will assign myself to #508 and produce another patch that takes care of any edge cases (alt+tab, stuff like that).

[Jay Weisskopf]

Oh, I forgot to mention that this has only been tested on Windows, but if you're using native SDL on the other platforms, there shouldn't be any issues. I've done some work on this exact same issue for another project, which is SDL-based, so I'm comfortable with its API.

[Philip Taylor]

Okay, I'll commit this one for now. I tried it on OS X and it looks like fullscreen is already pretty broken and this doesn't make it any worse, so I'll leave those problems for some competent Mac developer to come and fix. Multi-monitor fullscreen on Linux doesn't work (it fills the bounding box of all monitors; I think that's SDL's responsibility, not ours) so this doesn't have any effect there so that's okay.

[philip]

(In [8022]) Fix #545 (Grab mouse in fullscreen), based on patch from Jayschwa

[(none)]

Milestone Unclassified deleted

[Vladislav Belov]

In 27603:

Adds an option to disable mouse grab in fullscreen.

Refs #6649
Refs #545

Differential Revision: ​https://code.wildfiregames.com/D4974