Some construction sites not being progressed in a24 - animals not leaving foundations

[elexis]

In this a24 testgame ​https://www.youtube.com/watch?v=uqHzawvxhO8 at
27:22 ​https://youtu.be/uqHzawvxhO8?t=1642
35:00 ​https://youtu.be/uqHzawvxhO8?t=2100
40:00 ​https://youtu.be/uqHzawvxhO8?t=2414

there was a construction site that was not being progressed or completed.

[wraitii]

I believe the cause is animals (or units) not properly leaving foundations. This has been fixed upstream (through various diffs) but needs to be tested after that.

[Freagarach]

I was just testing something else and I found that of some dead entities don't have their obstruction boxes removed, this might also be part of the problem perhaps? (It also hinders pathfinding.)

[wraitii]

Freagarach: ​https://github.com/wraitii/0ad/commit/3dd0fa9307f5712de3154e250c8816e6c40a4108

Feel free to raise a ticket but it's going to be fixed.

[Krinkle]

The issue of (living) animals/chickens blocking a building's foundation from progressing is covered by #5454.

[wraitii]

Indeed this is sort of a duplicate of #5454 - I'll keep both because 5454 is a specific case where units were stuck in walking state, not the more general case of "units can't leave foundations".

This more general case ifs fixed already. This particular instance was fixed mostly by ​Phab:rP22416 and ​Phab:rP22422, which made sure units correctly moved out of range.