#5490 closed defect (fixed)
Don't download HTML error pages in build-osx-libs.sh
| Reported by: | historic_bruno | Owned by: | historic_bruno |
|---|---|---|---|
| Priority: | Should Have | Milestone: | Alpha 24 |
| Component: | Build & Packages | Keywords: | |
| Cc: | Patch: |
Description (last modified by )
Currently the function download_lib in build-osx-libs.sh uses curl to download the source tarballs. However, the files might move or the URL may be incorrectly configured. In these cases, the error pages are saved with the tarball filename as a successful download, and the script proceeds as if nothing happened.
This can be resolved by adding the -f flag to curl, so it fails immediately on e.g. 404 errors.
Also, the -O flag could replace -o, but we need to verify both these flags are available on the oldest macOS we support, currently 10.9.
Change History (3)
comment:1 by , 5 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 5 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:3 by , 5 years ago
| Milestone: | Backlog → Alpha 24 |
|---|
Note:
See TracTickets
for help on using tickets.
In 22493: