build crash due to system config header

[Karol Trzcionka]

I've got an error while building 0ad:

../../../source/tools/atlas/AtlasUI/Misc/DLLInterface.cpp: In member function ‘virtual bool AtlasDLLApp::OnInit()’:
../../../source/tools/atlas/AtlasUI/Misc/DLLInterface.cpp:191:28: error: ‘wxHandleFatalExceptions’ was not declared in this scope

It is because the wxHandleFatalExceptions' declaration in wx-2.8/wx/utils.h depend on config in wx/setup.h where I have "#define wxUSE_ON_FATAL_EXCEPTION 0". I can see in utils.h:

#if wxUSE_ON_FATAL_EXCEPTION

// should wxApp::OnFatalException() be called?
WXDLLIMPEXP_BASE bool wxHandleFatalExceptions(bool doit = true);

#endif // wxUSE_ON_FATAL_EXCEPTION

I've disabled debugger's checking locally like in attached patch but I think it is not the best solution.

[Philip Taylor]

I think that solution sounds fine - if wx doesn't provide wxHandleFatalExceptions then there's nothing else we can do, and fatal exceptions will just crash the program, which is okay.

[philip]

(In [8044]) Fix #553 (build error when wxUSE_ON_FATAL_EXCEPTION disabled), based on patch from Karlik

[(none)]

Milestone Unclassified deleted