Jenkins VS2015 build warnings go unreported on Phabricator

[elexis]

Perhaps reported in the wrong place, but:

In ​Phab:D2271 (​https://code.wildfiregames.com/) there was a C++ diff that triggered a VS2015 build warning (no warning on clang nor c++), but did not report it on Phabricator.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/141/display/redirect

Only if one had clicked the log, one would have seen the warning:

E:\Jenkins\workspace\vs2015-differential>cd build\workspaces\vc2015   && MSBuild.exe pyrogenesis.sln /m:2 /p:PlatformToolset=v140_xp /t:pyrogenesis /t:test /p:Configuration=Release -clp:Warningsonly -clp:ErrorsOnly 

Microsoft (R) Build Engine version 14.0.25420.1

Copyright (C) Microsoft Corporation. All rights reserved.


     7>XmppClient.obj : warning LNK4006: "public: static void __cdecl ScriptInterface::ToJSVal<class glooxwrapper::string>(struct JSContext *,class JS::MutableHandle<class JS::Value>,class glooxwrapper::string const &)" (??$ToJSVal@Vstring@glooxwrapper@@@ScriptInterface@@SAXPAUJSContext@@V?$MutableHandle@VValue@JS@@@JS@@ABVstring@glooxwrapper@@@Z) already defined in GlooxScriptConversions.obj; second definition ignored [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vc2015\lobby.vcxproj]

     7>XmppClient.obj : warning LNK4006: "public: static void __cdecl ScriptInterface::ToJSVal<enum gloox::CertStatus>(struct JSContext *,class JS::MutableHandle<class JS::Value>,enum gloox::CertStatus const &)" (??$ToJSVal@W4CertStatus@gloox@@@ScriptInterface@@SAXPAUJSContext@@V?$MutableHandle@VValue@JS@@@JS@@ABW4CertStatus@gloox@@@Z) already defined in GlooxScriptConversions.obj; second definition ignored [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vc2015\lobby.vcxproj]

     7>XmppClient.obj : warning LNK4006: "public: static void __cdecl ScriptInterface::ToJSVal<enum gloox::ConnectionError>(struct JSContext *,class JS::MutableHandle<class JS::Value>,enum gloox::ConnectionError const &)" (??$ToJSVal@W4ConnectionError@gloox@@@ScriptInterface@@SAXPAUJSContext@@V?$MutableHandle@VValue@JS@@@JS@@ABW4ConnectionError@gloox@@@Z) already defined in GlooxScriptConversions.obj; second definition ignored [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vc2015\lobby.vcxproj]

     7>XmppClient.obj : warning LNK4006: "public: static void __cdecl ScriptInterface::ToJSVal<enum gloox::MUCRoomRole>(struct JSContext *,class JS::MutableHandle<class JS::Value>,enum gloox::MUCRoomRole const &)" (??$ToJSVal@W4MUCRoomRole@gloox@@@ScriptInterface@@SAXPAUJSContext@@V?$MutableHandle@VValue@JS@@@JS@@ABW4MUCRoomRole@gloox@@@Z) already defined in GlooxScriptConversions.obj; second definition ignored [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vc2015\lobby.vcxproj]

     7>XmppClient.obj : warning LNK4006: "public: static void __cdecl ScriptInterface::ToJSVal<enum gloox::Presence::PresenceType>(struct JSContext *,class JS::MutableHandle<class JS::Value>,enum gloox::Presence::PresenceType const &)" (??$ToJSVal@W4PresenceType@Presence@gloox@@@ScriptInterface@@SAXPAUJSContext@@V?$MutableHandle@VValue@JS@@@JS@@ABW4PresenceType@Presence@gloox@@@Z) already defined in GlooxScriptConversions.obj; second definition ignored [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vc2015\lobby.vcxproj]

     7>XmppClient.obj : warning LNK4006: "public: static void __cdecl ScriptInterface::ToJSVal<enum gloox::RegistrationResult>(struct JSContext *,class JS::MutableHandle<class JS::Value>,enum gloox::RegistrationResult const &)" (??$ToJSVal@W4RegistrationResult@gloox@@@ScriptInterface@@SAXPAUJSContext@@V?$MutableHandle@VValue@JS@@@JS@@ABW4RegistrationResult@gloox@@@Z) already defined in GlooxScriptConversions.obj; second definition ignored [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vc2015\lobby.vcxproj]

     7>XmppClient.obj : warning LNK4006: "public: static void __cdecl ScriptInterface::ToJSVal<enum gloox::StanzaError>(struct JSContext *,class JS::MutableHandle<class JS::Value>,enum gloox::StanzaError const &)" (??$ToJSVal@W4StanzaError@gloox@@@ScriptInterface@@SAXPAUJSContext@@V?$MutableHandle@VValue@JS@@@JS@@ABW4StanzaError@gloox@@@Z) already defined in GlooxScriptConversions.obj; second definition ignored [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vc2015\lobby.vcxproj]

So it went unnoticed until some later unrelated revision proposal had a build failure and spammed the warnings prior to the build error.

[elexis]

In 22919:

Fix wrong GlooxScriptConversions include in rP22856 / D2264 triggering VS2015 build warning but no clang build warning, refs #5596.

Differential Revision: ​https://code.wildfiregames.com/D2298
Tested on: clang 8.0.1., Jenkins

[Stan]

In r24817:

Allow the windows CI to post comments on differentials like other pipelines.

Differential Revision: ​https://code.wildfiregames.com/D2946